Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](autopick)When the PR is merged, adding a label afterward should also trigger the workflow. #44057

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[chore](autopick)When the PR is merged, adding a label afterward should also trigger the workflow. #44057

merged 1 commit into from
Nov 17, 2024

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Nov 15, 2024 •
edited
Loading

Important Note:

There’s a potential issue here: if the label was added before the merge and later removed and then readd, the workflow may still be triggered again. Please avoid performing these operations repeatedly, as CI resources are valuable.

@CalvinKirs
[chore](autopick)When the PR is merged, adding a label afterward shou…
dde7522 
…ld also trigger the workflow.

## Important Note:
There’s a potential issue here: if the label was added before the merge and later removed, the workflow may still be triggered again. Please avoid performing these operations repeatedly, as CI resources are valuable.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

dataroaring
dataroaring approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airborne12
airborne12 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dataroaring dataroaring merged commit db03e33 into apache:master Nov 17, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CalvinKirs @doris-robot @morningman @airborne12 @dataroaring