Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) explicit message when parse file_cache_path error #44004

Merged
merged 4 commits into from
Nov 18, 2024
Merged

[fix](cloud) explicit message when parse file_cache_path error #44004

merged 4 commits into from
Nov 18, 2024

Conversation

freemandealer
Copy link
Contributor

What problem does this PR solve?

print more explicit reason why file_cache_path fail to parse

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen
hello-stephen previously approved these changes Nov 15, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.97% (9901/26073)
Line Coverage: 29.16% (82716/283644)
Region Coverage: 28.29% (42500/150253)
Branch Coverage: 24.86% (21550/86682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4ef0f8960d50301b4e6c95105723ad1221e84bdc_4ef0f8960d50301b4e6c95105723ad1221e84bdc/report/index.html

dataroaring
dataroaring approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@gavinchou gavinchou merged commit c050f54 into apache:master Nov 18, 2024
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
@freemandealer
[fix](cloud) explicit message when parse file_cache_path error (#44004)
a2673e9 
print more explicit reason why file_cache_path fail to parse
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@github-actions @freemandealer
branch-3.0: [fix](cloud) explicit message when parse file_cache_path …
590459b 
…error #44004 (#44157)

Cherry-picked from #44004

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@hello-stephen hello-stephen hello-stephen left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freemandealer @doris-robot @gavinchou @hello-stephen @dataroaring