Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compaction) reduce memory cost for cloud compaction of mow table (#43502) #43633

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[fix](compaction) reduce memory cost for cloud compaction of mow table (#43502) #43633

merged 2 commits into from
Nov 12, 2024

Conversation

zhannngchen
Copy link
Contributor

cherry-pick #43502

@zhannngchen
[fix](compaction) reduce memory cost for cloud compaction of mow table (
f6956b7 
apache#43502)

Related PR: apache#36865

Problem Summary:

But when we merge the codes for cloud, such optimization is not applied
for cloud compaction
We found several cases that compaction of MoW table consume lots of
memory on cloud, this PR try to fix this issue

Co-authored-by: Chen Zhang <zhangchen@selectdb.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhannngchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen merged commit f72ff09 into apache:branch-3.0 Nov 12, 2024
21 of 23 checks passed
@zhannngchen zhannngchen mentioned this pull request Nov 13, 2024
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Nov 14, 2024
@zhannngchen
[fix](cloud-mow) fix compaction missed rows dcheck fail (#43909)
bf8ce94 
Related PR: #43633 

Introduced through the cherry-pick of #43633 
```
F20241113 03:01:36.481637 19123 cloud_tablet.cpp:818] Check failed: missed_rows->size() == missed_rows_size (9 vs. 0)
```
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@zhannngchen @gavinchou
[fix](compaction) reduce memory cost for cloud compaction of mow table (
35fb132 
apache#43502) (apache#43633)

cherry-pick apache#43502
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@zhannngchen @gavinchou
[fix](cloud-mow) fix compaction missed rows dcheck fail (apache#43909)
8664a2e 
Related PR: apache#43633 

Introduced through the cherry-pick of apache#43633 
```
F20241113 03:01:36.481637 19123 cloud_tablet.cpp:818] Check failed: missed_rows->size() == missed_rows_size (9 vs. 0)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhannngchen @doris-robot