Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](common) replace readAllBytes which not supported in jdk8 #43565

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 11, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #43516

Problem Summary:

GZIPInputStream.readAllBytes is introduced in JDK 9, so this PR replaces readAllBytes by IOUtils.toByteArray

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Nov 11, 2024

run buildall

w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 11, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 51499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c32dbe97c3593f2fb0f9871ecb45c66a4d348abc, data reload: false

------ Round 1 ----------------------------------
q1	17581	7459	7371	7371
q2	2575	1303	1298	1298
q3	10059	1145	1128	1128
q4	10357	821	908	821
q5	7587	2913	2926	2913
q6	231	143	146	143
q7	1026	623	594	594
q8	9385	2365	2366	2365
q9	12463	12298	12389	12298
q10	7134	2433	2453	2433
q11	459	258	258	258
q12	406	213	209	209
q13	17779	3037	3035	3035
q14	237	212	204	204
q15	578	527	522	522
q16	676	601	581	581
q17	972	565	584	565
q18	7278	6726	6791	6726
q19	1329	1038	886	886
q20	3085	2826	2811	2811
q21	4008	3242	2995	2995
q22	1414	1365	1343	1343
Total cold run time: 116619 ms
Total hot run time: 51499 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7631	7467	7560	7467
q2	327	251	253	251
q3	3001	2959	2914	2914
q4	2068	1769	1839	1769
q5	5663	5512	5657	5512
q6	225	139	132	132
q7	2181	1815	1860	1815
q8	3418	3512	3518	3512
q9	14543	14454	14500	14454
q10	3619	3561	3523	3523
q11	587	507	499	499
q12	820	618	641	618
q13	10698	3229	3268	3229
q14	320	273	253	253
q15	594	534	557	534
q16	673	634	639	634
q17	1812	1615	1584	1584
q18	8130	7792	7533	7533
q19	1667	1612	1423	1423
q20	2185	1967	1918	1918
q21	5439	5376	5342	5342
q22	625	564	539	539
Total cold run time: 76226 ms
Total hot run time: 65455 ms

@w41ter w41ter merged commit dafca98 into master Nov 11, 2024
34 of 36 checks passed
@w41ter w41ter deleted the support_jdk_8 branch November 11, 2024 08:44
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants