[Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem by LiBinfeng-01 · Pull Request #43422 · apache/doris

LiBinfeng-01 · 2024-11-07T08:23:56Z

What problem does this PR solve?

Problem
function like select floor(300.343, 2) precision should be 5 and scale should be 2, but now is (6, 2) after compute precision, but after folding const on fe, it changed to (5, 2) but upper level of plan still expect the output of child to be (6, 2). So it would rise an exception when executing.
How it was fixed
fix folding constant precision of floor/round/ceil/truncate functions from (5, 2) to (6, 2) in upper case
Notion
when second value is negative and it absolute value >= precision - value, it can not be expressed in fe which result is zero with decimal type (3, 0). like 000. So just let it go back and no using folding constant by fe.

Issue Number: close #43421

Related PR: #40744

Problem Summary:

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No colde files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.
Release note

Fix floor/round/ceil functions precision problem

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-07T08:24:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

LiBinfeng-01 · 2024-11-07T08:25:54Z

run buildall

github-actions · 2024-11-07T08:41:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-07T08:41:59Z

PR approved by anyone and no changes requested.

superdiaodiao · 2024-11-07T11:48:21Z

...sion-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy

+    testFoldConst("with cte as (select floor(300.343, 2) order by 1 limit 1) select * from cte")
+    testFoldConst("with cte as (select round(300.343, 2) order by 1 limit 1) select * from cte")
+    testFoldConst("with cte as (select ceil(300.343, 2) order by 1 limit 1) select * from cte")


I tested the query before this PR:
with cte as (select truncate(300.343, 2) order by 1 limit 1) select * from cte;,
and the exception is:
ERROR 1105 (HY000): errCode = 2, detailMessage = (9.134.238.135)[INTERNAL_ERROR]output type not match expr type , col name , expected type Decimal(6, 2) , real type Decimal(5, 2).
So whether the truncate() should be tested together?

it make sense, added

LiBinfeng-01 · 2024-11-08T03:32:00Z

run buildall

LiBinfeng-01 · 2024-11-08T03:34:44Z

run buildall

LiBinfeng-01 · 2024-11-08T05:08:46Z

run p0

LiBinfeng-01 · 2024-11-08T05:08:53Z

run cloud_p0

LiBinfeng-01 · 2024-11-11T06:08:49Z

run buildall

morrySnow · 2024-11-11T06:38:51Z

.../java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java

    public static Expression truncate(DecimalV3Literal first, IntegerLiteral second) {
        if (first.getValue().compareTo(BigDecimal.ZERO) == 0) {
            return first;
+        } else if (first.getValue().compareTo(BigDecimal.ZERO) == -1) {


Suggested change

} else if (first.getValue().compareTo(BigDecimal.ZERO) == -1) {

} else if (first.getValue().compareTo(BigDecimal.ZERO) < 0) {

the function compareTo only return 0 -1 and 1, so I think -1 is acceptable for this situation

you wrong. https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T-

https://docs.oracle.com/javase/8/docs/api/java/math/BigDecimal.html
maybe you can check bigDecimal Type implementation for compareTo

changed to aligning interface definition

LiBinfeng-01 · 2024-11-11T09:55:32Z

run buildall

LiBinfeng-01 · 2024-11-12T04:09:42Z

run buildall

…recision when fold constant

LiBinfeng-01 · 2024-11-12T07:54:12Z

run buildall

LiBinfeng-01 · 2024-11-12T08:56:48Z

run buildall

github-actions · 2024-11-12T11:46:18Z

PR approved by at least one committer and no changes requested.

…recision problem (#43422) - Problem function like ```select floor(300.343, 2)``` precision should be 5 and scale should be 2, but now is (6, 2) after compute precision, but after folding const on fe, it changed to (5, 2) but upper level of plan still expect the output of child to be (6, 2). So it would rise an exception when executing. - How it was fixed fix folding constant precision of floor/round/ceil/truncate functions from (5, 2) to (6, 2) in upper case - Notion when second value is negative and it absolute value >= precision - value, it can not be expressed in fe which result is zero with decimal type (3, 0). like 000. So just let it go back and no using folding constant by fe. - Related PR: #40744 - Release note Fix floor/round/ceil functions precision problem in folding constant

…recision problem (apache#43422) - Problem function like ```select floor(300.343, 2)``` precision should be 5 and scale should be 2, but now is (6, 2) after compute precision, but after folding const on fe, it changed to (5, 2) but upper level of plan still expect the output of child to be (6, 2). So it would rise an exception when executing. - How it was fixed fix folding constant precision of floor/round/ceil/truncate functions from (5, 2) to (6, 2) in upper case - Notion when second value is negative and it absolute value >= precision - value, it can not be expressed in fe which result is zero with decimal type (3, 0). like 000. So just let it go back and no using folding constant by fe. - Related PR: apache#40744 - Release note Fix floor/round/ceil functions precision problem in folding constant

…pe compute precision problem (#43782) Cherry-picked from #43422 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

…pe compute precision problem (#43781) Cherry-picked from #43422 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

…ecision problem (apache#43782) Cherry-picked from apache#43422

LiBinfeng-01 added dev/2.1.x dev/3.0.x labels Nov 7, 2024

morrySnow previously approved these changes Nov 7, 2024

View reviewed changes

morrySnow added the p0_b label Nov 7, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 7, 2024

github-actions bot added the reviewed label Nov 7, 2024

superdiaodiao reviewed Nov 7, 2024

View reviewed changes

LiBinfeng-01 dismissed morrySnow’s stale review via e9abaf6 November 8, 2024 03:30

LiBinfeng-01 force-pushed the fix_doris_16510 branch from c2c876d to e9abaf6 Compare November 8, 2024 03:30

LiBinfeng-01 changed the title ~~[Fix](Nereids) fix floor/round/ceil functions type compute precision problem~~ [Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem Nov 8, 2024

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 8, 2024

morrySnow reviewed Nov 11, 2024

View reviewed changes

LiBinfeng-01 force-pushed the fix_doris_16510 branch from 3715356 to 309671a Compare November 12, 2024 04:09

[Fix](Nereids) fix floor/round/ceil/truncate functions type compute p…

84dc072

…recision when fold constant

LiBinfeng-01 force-pushed the fix_doris_16510 branch from 309671a to 84dc072 Compare November 12, 2024 07:54

fix compare to forward to interface

e580d91

englefly approved these changes Nov 12, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024

starocean999 approved these changes Nov 12, 2024

View reviewed changes

morrySnow approved these changes Nov 12, 2024

View reviewed changes

morrySnow merged commit 3fffc61 into apache:master Nov 12, 2024

github-actions bot mentioned this pull request Nov 12, 2024

branch-3.0: [Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem #43781

Merged

github-actions bot mentioned this pull request Nov 12, 2024

branch-2.1: [Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem #43782

Merged

LiBinfeng-01 mentioned this pull request Nov 12, 2024

[Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem (#43422) #43788

Closed

16 tasks

LiBinfeng-01 mentioned this pull request Nov 12, 2024

[Fix](Nereids) fix floor/round/ceil/truncate functions type compute precision problem (#43422) #43789

Closed

16 tasks

yiguolei pushed a commit that referenced this pull request Nov 13, 2024

branch-2.1: [Fix](Nereids) fix floor/round/ceil/truncate functions ty…

9d4405d

…pe compute precision problem (#43782) Cherry-picked from #43422 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

yiguolei added dev/2.1.8-merged and removed dev/2.1.x labels Nov 13, 2024

morrySnow pushed a commit that referenced this pull request Nov 13, 2024

branch-3.0: [Fix](Nereids) fix floor/round/ceil/truncate functions ty…

6e8a80d

…pe compute precision problem (#43781) Cherry-picked from #43422 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>

morrySnow added dev/3.0.3-merged 3.0.x and removed dev/3.0.x 3.0.x labels Nov 13, 2024

GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025

fix(Nereids): fix floor/round/ceil/truncate functions type compute pr…

5f243b7

…ecision problem (apache#43782) Cherry-picked from apache#43422

	} else if (first.getValue().compareTo(BigDecimal.ZERO) == -1) {
	} else if (first.getValue().compareTo(BigDecimal.ZERO) < 0) {

Conversation

LiBinfeng-01 commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 7, 2024

Uh oh!

LiBinfeng-01 commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

superdiaodiao Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 commented Nov 8, 2024

Uh oh!

LiBinfeng-01 commented Nov 8, 2024

Uh oh!

LiBinfeng-01 commented Nov 8, 2024

Uh oh!

LiBinfeng-01 commented Nov 8, 2024

Uh oh!

LiBinfeng-01 commented Nov 11, 2024

Uh oh!

morrySnow Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

morrySnow Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

LiBinfeng-01 commented Nov 11, 2024

Uh oh!

LiBinfeng-01 commented Nov 12, 2024

Uh oh!

LiBinfeng-01 commented Nov 12, 2024

Uh oh!

LiBinfeng-01 commented Nov 12, 2024

Uh oh!

github-actions bot commented Nov 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LiBinfeng-01 commented Nov 7, 2024 •

edited

Loading

superdiaodiao Nov 7, 2024 •

edited

Loading