Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)add physical property in post processor #42862

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Oct 29, 2024

Proposed changes

Post rule ProjectAggregateExpressionsForCse may add new Project node into plan, but does not set physical properties for the new project, and hence breaks the function of local shuffle.
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@englefly
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor

add desc please

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test case please

@englefly englefly force-pushed the phy-properties-missing branch from de46c3a to 1f80ec5 Compare October 31, 2024 06:26
@englefly
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 31, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit 1713e26 into apache:master Oct 31, 2024
26 of 28 checks passed
@englefly englefly deleted the phy-properties-missing branch October 31, 2024 08:41
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
## Proposed changes
Post rule ProjectAggregateExpressionsForCse may add new Project node
into plan, but does not set physical properties for the new project, and
hence breaks the function of local shuffle.
Issue Number: close #xxx

<!--Describe your changes.-->
englefly added a commit to englefly/incubator-doris that referenced this pull request Nov 15, 2024
## Proposed changes
Post rule ProjectAggregateExpressionsForCse may add new Project node
into plan, but does not set physical properties for the new project, and
hence breaks the function of local shuffle.
Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Nov 19, 2024
…-3.0 (#44027)

pick #42862

Post rule ProjectAggregateExpressionsForCse may add new Project node
into plan, but does not set physical properties for the new project, and
hence breaks the function of local shuffle.
Issue Number: close #xxx
morrySnow pushed a commit that referenced this pull request Nov 27, 2024
…3001)

Cherry-picked from #42862

Co-authored-by: minghong <zhouminghong@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants