-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](decommission) decommission backend skip leaky tablets #42401
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
26ca8da
to
6f3c533
Compare
run buildall |
run p0 |
TPC-H: Total hot run time: 41074 ms
|
TPC-DS: Total hot run time: 192670 ms
|
ClickBench: Total hot run time: 32.62 s
|
run p0 |
6f3c533
to
4f5da66
Compare
run buildall |
TPC-H: Total hot run time: 41142 ms
|
TPC-DS: Total hot run time: 192040 ms
|
ClickBench: Total hot run time: 32.65 s
|
4f5da66
to
f098fd4
Compare
run buildall |
f098fd4
to
42b980a
Compare
run buildall |
42b980a
to
a1872dc
Compare
run buildall |
a1872dc
to
dec14ae
Compare
run buildall |
TPC-H: Total hot run time: 41269 ms
|
TPC-DS: Total hot run time: 191766 ms
|
ClickBench: Total hot run time: 32.3 s
|
run p0 |
2 similar comments
run p0 |
run p0 |
run buildall |
TPC-H: Total hot run time: 41867 ms
|
run buildall |
TPC-H: Total hot run time: 41174 ms
|
TPC-DS: Total hot run time: 196246 ms
|
ClickBench: Total hot run time: 32.61 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 41158 ms
|
TPC-DS: Total hot run time: 195373 ms
|
ClickBench: Total hot run time: 32.59 s
|
run buildall |
run buildall |
TPC-H: Total hot run time: 41755 ms
|
TPC-DS: Total hot run time: 196390 ms
|
ClickBench: Total hot run time: 32.66 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
When decommission a backend, it will get this backend's tablet meta list from TabletInvertIndex. Only after all its tablets had migrated or moved to recyle bin, then can drop this backend.
But sometimes, TabletInvertIndex may had leaky because deletting a partition forget to delete its tablet meta. After that, decommission will be blocked. So let decommission skip the leaky tablet metas, if a tablet meta couldn't found its partition, and not in catalog recyle bin, that just skip it. But for safy reason, let drop after leaky had exceed 5 hours(Config.decommission_skip_leaky_tablet_second).