Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](doris compose) start node wait for ready service #42266

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Oct 22, 2024

when SuiteCluster call start/restart frontends and backends, it will wait nodes ready for service.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777 yujun777 force-pushed the start-wait-node-ready branch from ff46198 to 55d0263 Compare October 23, 2024 06:57
@yujun777 yujun777 marked this pull request as ready for review October 23, 2024 07:08
@yujun777
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Oct 23, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yujun777
Copy link
Collaborator Author

run p0

@yujun777
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yujun777 yujun777 changed the title [improvement](doris compose) start node wait for ready service [feature](doris compose) start node wait for ready service Oct 25, 2024
@dataroaring dataroaring merged commit 19a00cf into apache:master Oct 28, 2024
26 of 27 checks passed
dataroaring pushed a commit that referenced this pull request Oct 29, 2024
gavinchou pushed a commit that referenced this pull request Oct 29, 2024
…izable (#42605)

due to #42266
Fix 
```
python -W ignore /mnt/disk2/dengxin/apache_doris/docker/runtime/doris-compose/doris-compose.py stop test_clean_tablet_when_rebalance --be-id 1 --outpu
t-json
{
    "code": 1,
    "err": "Traceback (most recent call last):\n  File \"/mnt/disk2/dengxin/apache_doris/docker/runtime/doris-compose/doris-compose.py\", line 59, in <module>\n    print(utils.pretty_json({\"code\": 0, \"data\": data}), flush=True)\n  F
ile \"/mnt/disk2/dengxin/apache_doris/docker/runtime/doris-compose/utils.py\", line 324, in pretty_json\n    return json.dumps(json_data, indent=4, sort_keys=True)\n  File \"/usr/lib64/python3.6/json/__init__.py\", line 238, in dumps\n
   **kw).encode(obj)\n  File \"/usr/lib64/python3.6/json/encoder.py\", line 201, in encode\n    chunks = list(chunks)\n  File \"/usr/lib64/python3.6/json/encoder.py\", line 430, in _iterencode\n    yield from _iterencode_dict(o, _curren
t_indent_level)\n  File \"/usr/lib64/python3.6/json/encoder.py\", line 404, in _iterencode_dict\n    yield from chunks\n  File \"/usr/lib64/python3.6/json/encoder.py\", line 325, in _iterencode_list\n    yield from chunks\n  File \"/usr
/lib64/python3.6/json/encoder.py\", line 437, in _iterencode\n    o = _default(o)\n  File \"/usr/lib64/python3.6/json/encoder.py\", line 180, in default\n    o.__class__.__name__)\nTypeError: Object of type 'Cluster' is not JSON seriali
zable\n"
}
```
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants