Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement](statistics)Drop expired external stats only when the catalog is dropped. #42244

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Oct 22, 2024

Drop expired external stats only when the catalog is dropped, to reduce meta store access.
Before, we go through all external catalogs and their DBs and tables to check expired stats, which may bring lots of meta store access.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review October 22, 2024 06:46
@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run feut

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run feut

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zfr9527 zfr9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibing-Li Jibing-Li merged commit 38313fc into apache:master Oct 24, 2024
26 of 28 checks passed
@Jibing-Li Jibing-Li deleted the clean branch October 24, 2024 08:31
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 24, 2024
…talog is dropped. (apache#42244)

Drop expired external stats only when the catalog is dropped, to reduce
meta store access.
Before, we go through all external catalogs and their DBs and tables to
check expired stats, which may bring lots of meta store access.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 24, 2024
…talog is dropped. (apache#42244)

Drop expired external stats only when the catalog is dropped, to reduce
meta store access.
Before, we go through all external catalogs and their DBs and tables to
check expired stats, which may bring lots of meta store access.
Jibing-Li added a commit that referenced this pull request Oct 24, 2024
Jibing-Li added a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants