Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](index compaction) fix fd leak and mem leak while index compaction (#41915) #42171

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[fix](index compaction) fix fd leak and mem leak while index compaction (#41915) #42171

merged 2 commits into from
Oct 24, 2024

Conversation

cambyzju
Copy link
Contributor

pick #41915 to branch-2.1

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.01% (9347/25954)
Line Coverage: 27.59% (76818/278386)
Region Coverage: 26.40% (39458/149457)
Branch Coverage: 23.19% (20085/86622)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b31bf06c92da602a8fab32607651fc415dc09f16_b31bf06c92da602a8fab32607651fc415dc09f16/report/index.html

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.01% (9349/25964)
Line Coverage: 27.57% (76784/278490)
Region Coverage: 26.39% (39454/149500)
Branch Coverage: 23.17% (20079/86648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7599974994e0b108d1da93d3b7c0dc0d62f32ddc_7599974994e0b108d1da93d3b7c0dc0d62f32ddc/report/index.html

airborne12
airborne12 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju
Copy link
Contributor Author

run p0

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.04% (9362/25980)
Line Coverage: 27.60% (76930/278695)
Region Coverage: 26.39% (39512/149744)
Branch Coverage: 23.16% (20097/86756)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bb2e8ee004ec6c0cda0cfdc88c5733550dbaa17a_bb2e8ee004ec6c0cda0cfdc88c5733550dbaa17a/report/index.html

@cambyzju
Copy link
Contributor Author

run p0

@cambyzju
Copy link
Contributor Author

run P0 Regression

lide-reed
lide-reed approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 32b13b2 into apache:branch-2.1 Oct 24, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lide-reed lide-reed lide-reed approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cambyzju @doris-robot @lide-reed @airborne12