Skip to content

[fix](cloud) Fix tablet_id is zero when txn lazy commit#42043

Merged
dataroaring merged 3 commits intoapache:masterfrom
swjtu-zhanglei:master-fix8
Oct 28, 2024
Merged

[fix](cloud) Fix tablet_id is zero when txn lazy commit#42043
dataroaring merged 3 commits intoapache:masterfrom
swjtu-zhanglei:master-fix8

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Oct 17, 2024 •
edited by gavinchou
Loading

  • when recycler and ms convert tmp rowsets at the same times, and finish convert task with different partitions severally, may cause tablet_id variable is zero

@doris-robot
Copy link

doris-robot commented Oct 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@swjtu-zhanglei swjtu-zhanglei changed the title [fix](cloud) Fix tablet_id is zere when txn lazy commit [fix](cloud) Fix tablet_id is zero when txn lazy commit Oct 17, 2024
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 21, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Oct 21, 2024
View reviewed changes
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 22, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Oct 24, 2024
View reviewed changes
cloud/src/meta-service/txn_lazy_committer.cpp Outdated
tmp_rowset_pb;
}

int64_t table_id = -1;
Copy link
Contributor

@gavinchou gavinchou Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

Copy link
Contributor Author

@swjtu-zhanglei swjtu-zhanglei Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

done

@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit
ba38259 
* when ry and ms convert tmp rowsets at the same times, and finish convert task
  with different partitions severally, may cause tablet_id variable is zero
@swjtu-zhanglei
fix some comments
135dff8
@swjtu-zhanglei
fix some comments
86cf70d
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Oct 24, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR approved by anyone and no changes requested.

deardeng
deardeng approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4bb7139 into apache:master Oct 28, 2024
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Oct 30, 2024
@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (apache#42043)
39cfd72 
* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero
@swjtu-zhanglei swjtu-zhanglei mentioned this pull request Oct 30, 2024
Merged
dataroaring pushed a commit that referenced this pull request Oct 31, 2024
@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (#42043) (#42905
79b6a99 
)

* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@deardeng deardeng deardeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei @doris-robot @deardeng @gavinchou @dataroaring