Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick](branch-2.1) add parquet tvf cases and fix some parquet bug #41931

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Oct 16, 2024

Proposed changes

pick pr:
#41683
#41506
#41338
#40379

suxiaogang223 and others added 5 commits October 16, 2024 10:26
Start docker in parallel to reduce external pipeline time
…he#41506)

## Proposed changes
Reason: https://issues.apache.org/jira/browse/ARROW-5322
Java readers(parquet-mr) handles "dictionaryPageOffset = 0" to determine
if dictionary page exists where as the C readers uses
"has_dictionaryPageOffset" (_isset bit in thrift message) to determine
the same resulting in incompatible behaviours.
Therefore, we should consider that dicttionary page exists when both
`__isset.dictionary_page_offset` is true and `dictionary_page_offset` is
greater than 0.
## Proposed changes
Implemented reading parqeut files with decimal256 type
…der (apache#41683)

## Proposed changes
Impl ByteStreamSplitDecoder to decode BYTE_STREAM_SPLIT encoding
parquet.
relate pr: apache/arrow#42372

> Apache Parquet does not have any encodings suitable for FP data and
the available text compressors (zstd, gzip, etc) do not handle FP data
very well.
It is possible to apply a simple data transformation named "stream
splitting". Such could be "byte stream splitting" which creates K
streams of length N where K is the number of bytes in the data type (4
for floats, 8 for doubles) and N is the number of elements in the
sequence.

---------

Co-authored-by: morningman <morningman@163.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


#include "byte_stream_split.h"

#include <glog/logging.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'glog/logging.h' file not found [clang-diagnostic-error]

#include <glog/logging.h>
         ^

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.02% (9346/25950)
Line Coverage: 27.60% (76788/278218)
Region Coverage: 26.41% (39441/149366)
Branch Coverage: 23.19% (20073/86568)
Coverage Report: http://coverage.selectdb-in.cc/coverage/26132b1f6471b5e601ce31978459c093c3308360_26132b1f6471b5e601ce31978459c093c3308360/report/index.html

@yiguolei yiguolei merged commit 1b901f6 into apache:branch-2.1 Oct 17, 2024
18 of 21 checks passed
@suxiaogang223 suxiaogang223 deleted the parquet_hdfs_tvf_case branch October 17, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants