Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][DynamicPartition]Fix bug that Modify a dynamic partition property in a non-dynamic partition table will throw a Exception #4127

Merged
merged 4 commits into from
Aug 2, 2020
Merged

[Bug][DynamicPartition]Fix bug that Modify a dynamic partition property in a non-dynamic partition table will throw a Exception #4127

merged 4 commits into from
Aug 2, 2020

Conversation

WingsGo
Copy link
Contributor

@WingsGo WingsGo commented Jul 21, 2020

No description provided.

@WingsGo
[Bug][DynamicPartition]Fix bug that Modify a dynamic partition proper…
1eeaafb 
…ty in a non-dynamic partition table will throw a Exception
@WingsGo
Copy link
Contributor Author

WingsGo commented Jul 21, 2020

Ref #4126

morningman
morningman reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a UT for this?

@WingsGo
Copy link
Contributor Author

WingsGo commented Jul 25, 2020

Could you add a UT for this?

@morningman OK, done~

@WingsGo
Copy link
Contributor Author

WingsGo commented Jul 30, 2020

Hi, @morningman , I think the PR should included in 0.13-branch, can you review it? thx~~

morningman
morningman approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Aug 1, 2020
@morningman morningman added approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management branch-0.13 PR which need to merge to branch 0.13 labels Aug 1, 2020
@morningman
Copy link
Contributor

Hi, @morningman , I think the PR should included in 0.13-branch, can you review it? thx~~

OK

@morningman morningman merged commit d64d653 into apache:master Aug 2, 2020
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Aug 11, 2020
@WingsGo
[Bug][DynamicPartition]Fix bug that Modify a dynamic partition proper…
889c774 
…ty in a non-dynamic partition table will throw a Exception (apache#4127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels
approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management branch-0.13 PR which need to merge to branch 0.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WingsGo @morningman