Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](build) Change the return type of get_size in tablet_meta for MacOS compatibility. #41140

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Sep 23, 2024

auto size = tablet->tablet_meta()->delete_bitmap().get_size();
root.AddMember("size", size, root.GetAllocator());

The compiler complains because there is an ambiguity in the call when passing size to the constructor of rapidjson::GenericValue. This is because the type of size (which may be size_t or unsigned long) is 64 bits on ARM64-based Macs (such as the M1 chip), and RapidJSON provides multiple possible matching constructors.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Sep 23, 2024

run buildall

@zy-kkk zy-kkk changed the title [fix](build) Change the return type of in for MacOS compatibility. [fix](build) Change the return type of get_size in tablet_meta for MacOS compatibility. Sep 23, 2024
Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9605/25774)
Line Coverage: 28.67% (79476/277176)
Region Coverage: 28.13% (41118/146183)
Branch Coverage: 24.76% (20956/84622)
Coverage Report: http://coverage.selectdb-in.cc/coverage/16d4087f859df5b64b1e83c010fb9c429f282e31_16d4087f859df5b64b1e83c010fb9c429f282e31/report/index.html

@zy-kkk
Copy link
Member Author

zy-kkk commented Sep 24, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9605/25774)
Line Coverage: 28.69% (79517/277188)
Region Coverage: 28.12% (41112/146190)
Branch Coverage: 24.77% (20960/84626)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b989cc0aeb12287eeaa56d4e4dda37205ebf10fc_b989cc0aeb12287eeaa56d4e4dda37205ebf10fc/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zy-kkk zy-kkk merged commit 839c446 into apache:master Sep 24, 2024
22 of 26 checks passed
@zy-kkk zy-kkk deleted the fix_mac_build_0923 branch September 24, 2024 06:06
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
…r MacOS compatibility. (#41140)

```
auto size = tablet->tablet_meta()->delete_bitmap().get_size();
root.AddMember("size", size, root.GetAllocator());
```

The compiler complains because there is an ambiguity in the call when
passing size to the constructor of rapidjson::GenericValue. This is
because the type of size (which may be size_t or unsigned long) is 64
bits on ARM64-based Macs (such as the M1 chip), and RapidJSON provides
multiple possible matching constructors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants