-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](build) Change the return type of get_size
in tablet_meta
for MacOS compatibility.
#41140
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
get_size
in tablet_meta
for MacOS compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
TeamCity be ut coverage result: |
16d4087
to
b989cc0
Compare
run buildall |
TeamCity be ut coverage result: |
PR approved by at least one committer and no changes requested. |
…r MacOS compatibility. (#41140) ``` auto size = tablet->tablet_meta()->delete_bitmap().get_size(); root.AddMember("size", size, root.GetAllocator()); ``` The compiler complains because there is an ambiguity in the call when passing size to the constructor of rapidjson::GenericValue. This is because the type of size (which may be size_t or unsigned long) is 64 bits on ARM64-based Macs (such as the M1 chip), and RapidJSON provides multiple possible matching constructors.
The compiler complains because there is an ambiguity in the call when passing size to the constructor of rapidjson::GenericValue. This is because the type of size (which may be size_t or unsigned long) is 64 bits on ARM64-based Macs (such as the M1 chip), and RapidJSON provides multiple possible matching constructors.