-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement](cloud) dump error file when footer parse failure #40943
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
6d77ff5
to
15b4da5
Compare
run buildall |
15b4da5
to
95fc445
Compare
return Status::OK(); | ||
} | ||
|
||
std::string file_path = dir_path + std::to_string(cur_time) + "_" + ss.str(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use this pattern to get rid of duplicated dumps (check existence before read and write)
std::string file_path = dir_path + this->_rowset_id.to_string() + "_" + segment_id + "_" + offset + "_" + size;
run buildall |
TPC-H: Total hot run time: 41728 ms
|
TPC-DS: Total hot run time: 196374 ms
|
ClickBench: Total hot run time: 32.16 s
|
run buildall |
TPC-H: Total hot run time: 41749 ms
|
TPC-DS: Total hot run time: 195793 ms
|
ClickBench: Total hot run time: 32.47 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run beut |
run buildall |
TPC-H: Total hot run time: 41887 ms
|
TPC-DS: Total hot run time: 192135 ms
|
ClickBench: Total hot run time: 32.67 s
|
run buildall |
TPC-H: Total hot run time: 41324 ms
|
run beut |
TPC-DS: Total hot run time: 193865 ms
|
ClickBench: Total hot run time: 33.36 s
|
dump error file to local disk in cloud mode for better debug. limit the error file directory to avoid disk capacity problem. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
310a25b
to
f8a5baa
Compare
run buildall |
TPC-H: Total hot run time: 41313 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192678 ms
|
ClickBench: Total hot run time: 31.74 s
|
PR approved by at least one committer and no changes requested. |
dump error file to local disk in cloud mode for better debug. limit the error file directory to avoid disk capacity problem.
…e#40943) dump error file to local disk in cloud mode for better debug. limit the error file directory to avoid disk capacity problem.
…e#40943) dump error file to local disk in cloud mode for better debug. limit the error file directory to avoid disk capacity problem.
dump error file to local disk in cloud mode for better debug. limit the error file directory to avoid disk capacity problem.
Proposed changes
Issue Number: close #xxx