[Fix](Nereids) fix append_trailing_char_if_absent function return null#40820
Merged
morrySnow merged 2 commits intoapache:masterfrom Sep 18, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
reviewed
Sep 13, 2024
| } | ||
| default: { | ||
| return null; | ||
| throw new AnalysisException("Unexpected tag: " + tag); |
Contributor
There was a problem hiding this comment.
why change this? return null is correct because we do not want to throw exception
Contributor
Author
There was a problem hiding this comment.
here return null is reasonable, I check caller, they have deal with null. Let me restore this behavior
LiBinfeng-01
force-pushed
the
fix_function_append_trailing_char_if_absent
branch
from
1ff781d to
7e60ce3
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42772 ms |
TPC-DS: Total hot run time: 195890 ms |
ClickBench: Total hot run time: 31.06 s |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41505 ms |
TPC-DS: Total hot run time: 198636 ms |
ClickBench: Total hot run time: 32.39 s |
Contributor
Author
|
run cloud_p0 |
englefly
approved these changes
Sep 18, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Sep 18, 2024
This was referenced Sep 23, 2024
This was referenced Oct 16, 2024
Closed
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
apache#40820) example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
apache#40820) example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time
Closed
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Sep 26, 2025
…apache#41157) cherry-pick： apache#40820 example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example: select append_trailing_char_if_absent('it','a') would return null in original design, it can not return null when folding constant on fe any time