[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float #40290

jacktengg · 2024-09-02T16:49:25Z

Proposed changes

When casting decimal256 to float, BE first converting decimal256 to long double, and then converting to float, but for some values, the resulting float value is std::inf, this PR check this situation and report Arithmetic overflow.

CPP test:

int main()
{
        long double ld = std::stold("1.23456779999999999998e+67");
        std::cout << "long double: " << ld << std::endl;
        float f = static_cast<float>(ld);
        if (std::isnan(f)) {
            std::cout << "long double to float is nan" << std::endl;
        } else if (std::isinf(f)) {
            std::cout << "long double to float is inf" << std::endl;
        } else {
            std::cout << f << std::endl;
        }   
        double d = static_cast<double>(ld);
        if (std::isnan(d)) {
            std::cout << "long double to double is nan" << std::endl;
        } else if (std::isinf(d)) {
            std::cout << "long double to double is inf" << std::endl;
        } else {
            std::cout << "long double to double is " << d << std::endl;
        }   
        return 0;
}

result:

long double: 1.23457e+67
long double to float is inf
long double to double is 1.23457e+67

doris-robot · 2024-09-02T16:49:30Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

jacktengg · 2024-09-02T16:50:08Z

run buildall

github-actions · 2024-09-02T16:55:59Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-02T16:56:38Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-02T18:10:08Z

TPC-H: Total hot run time: 38180 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

------ Round 1 ----------------------------------
q1	18467	4508	4350	4350
q2	2033	186	174	174
q3	11611	1007	1035	1007
q4	10283	842	687	687
q5	7772	2851	2786	2786
q6	228	138	138	138
q7	967	614	606	606
q8	9325	2087	2097	2087
q9	7076	6546	6571	6546
q10	7005	2259	2188	2188
q11	467	237	239	237
q12	395	230	223	223
q13	18846	3074	3050	3050
q14	273	225	230	225
q15	519	496	492	492
q16	592	524	506	506
q17	993	667	755	667
q18	7495	6838	6875	6838
q19	1401	1101	1055	1055
q20	718	334	335	334
q21	3906	3079	2996	2996
q22	1124	988	1030	988
Total cold run time: 111496 ms
Total hot run time: 38180 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4334	4325	4295	4295
q2	382	275	263	263
q3	2890	2702	2677	2677
q4	1969	1627	1665	1627
q5	5685	5681	5845	5681
q6	226	130	134	130
q7	2213	1855	1815	1815
q8	3293	3439	3520	3439
q9	8860	8790	8788	8788
q10	3669	3404	3320	3320
q11	585	504	517	504
q12	816	688	665	665
q13	13668	3224	3284	3224
q14	313	271	292	271
q15	529	476	499	476
q16	627	587	589	587
q17	1851	1565	1557	1557
q18	8139	7951	7812	7812
q19	1727	1662	1527	1527
q20	2179	1885	1978	1885
q21	5690	5431	5583	5431
q22	1115	1037	1049	1037
Total cold run time: 70760 ms
Total hot run time: 57011 ms

doris-robot · 2024-09-02T18:22:18Z

TPC-DS: Total hot run time: 192271 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

query1	1256	896	854	854
query2	6311	2022	1961	1961
query3	10628	4052	4064	4052
query4	59934	23762	23196	23196
query5	5418	484	493	484
query6	410	165	165	165
query7	5880	289	288	288
query8	282	200	198	198
query9	8889	2459	2449	2449
query10	493	267	256	256
query11	18064	14987	15328	14987
query12	169	103	108	103
query13	1613	404	382	382
query14	10982	7682	7139	7139
query15	255	176	178	176
query16	7249	491	496	491
query17	1182	601	577	577
query18	1780	284	301	284
query19	292	149	146	146
query20	125	107	104	104
query21	207	104	104	104
query22	4613	4591	4741	4591
query23	34227	33313	33405	33313
query24	5904	2793	2829	2793
query25	530	372	373	372
query26	692	154	154	154
query27	1790	274	273	273
query28	3888	2061	2038	2038
query29	625	403	406	403
query30	228	155	157	155
query31	921	740	768	740
query32	82	51	49	49
query33	450	287	277	277
query34	841	461	474	461
query35	854	758	703	703
query36	1076	929	963	929
query37	141	89	96	89
query38	3961	3770	3927	3770
query39	1457	1400	1391	1391
query40	207	113	116	113
query41	48	47	44	44
query42	114	100	94	94
query43	522	484	478	478
query44	1067	734	737	734
query45	191	164	167	164
query46	1081	740	725	725
query47	1907	1811	1778	1778
query48	373	300	296	296
query49	762	423	444	423
query50	816	411	403	403
query51	6989	6946	6723	6723
query52	100	87	86	86
query53	250	178	177	177
query54	562	470	465	465
query55	80	76	75	75
query56	277	270	265	265
query57	1178	1055	1080	1055
query58	226	226	235	226
query59	3183	3039	2968	2968
query60	309	269	283	269
query61	124	122	118	118
query62	759	653	639	639
query63	218	182	186	182
query64	2936	755	760	755
query65	3197	3136	3179	3136
query66	705	365	350	350
query67	15464	15314	15395	15314
query68	3483	584	559	559
query69	408	278	283	278
query70	1168	1087	1099	1087
query71	365	272	273	272
query72	6232	4027	3975	3975
query73	747	324	326	324
query74	9025	8727	8804	8727
query75	3358	2704	2632	2632
query76	1428	945	1030	945
query77	566	317	307	307
query78	9769	9048	9121	9048
query79	1033	530	521	521
query80	666	511	498	498
query81	471	234	234	234
query82	243	146	143	143
query83	167	147	148	147
query84	251	74	76	74
query85	766	282	270	270
query86	319	299	258	258
query87	4459	4255	4338	4255
query88	2950	2307	2302	2302
query89	366	284	291	284
query90	2014	182	186	182
query91	121	100	105	100
query92	58	51	50	50
query93	1053	528	533	528
query94	717	296	286	286
query95	357	252	254	252
query96	587	269	260	260
query97	3204	3114	3095	3095
query98	207	200	205	200
query99	1508	1286	1226	1226
Total cold run time: 305410 ms
Total hot run time: 192271 ms

doris-robot · 2024-09-02T18:27:55Z

ClickBench: Total hot run time: 31.68 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.51	0.49	0.48
query6	1.14	0.75	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.54	0.50	0.49
query10	0.55	0.54	0.54
query11	0.15	0.12	0.12
query12	0.16	0.12	0.12
query13	0.62	0.59	0.59
query14	2.07	2.07	2.08
query15	0.83	0.82	0.82
query16	0.38	0.38	0.37
query17	1.06	1.01	1.02
query18	0.21	0.21	0.20
query19	1.94	1.83	1.78
query20	0.01	0.02	0.01
query21	15.40	0.67	0.67
query22	4.62	7.21	1.55
query23	18.28	1.37	1.24
query24	2.10	0.22	0.21
query25	0.14	0.08	0.07
query26	0.26	0.18	0.17
query27	0.09	0.08	0.07
query28	13.24	1.02	0.99
query29	12.66	3.42	3.39
query30	0.24	0.05	0.06
query31	2.87	0.40	0.39
query32	3.25	0.49	0.48
query33	2.95	3.02	3.10
query34	17.01	4.31	4.42
query35	4.44	4.45	4.42
query36	0.67	0.51	0.47
query37	0.19	0.15	0.15
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.26 s
Total hot run time: 31.68 s

jacktengg · 2024-09-03T02:03:28Z

run buildall

doris-robot · 2024-09-03T02:22:52Z

TPC-H: Total hot run time: 38298 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

------ Round 1 ----------------------------------
q1	17820	4454	4454	4454
q2	2521	185	183	183
q3	11186	1134	1186	1134
q4	10253	726	775	726
q5	7755	2933	2846	2846
q6	239	143	145	143
q7	990	636	615	615
q8	9388	2075	2090	2075
q9	7121	6576	6523	6523
q10	7023	2231	2244	2231
q11	448	236	242	236
q12	403	230	227	227
q13	17753	3105	3080	3080
q14	273	249	235	235
q15	519	480	469	469
q16	603	490	508	490
q17	968	635	616	616
q18	7509	6926	6731	6731
q19	1388	1023	1073	1023
q20	700	323	328	323
q21	3976	3016	2926	2926
q22	1080	1023	1012	1012
Total cold run time: 109916 ms
Total hot run time: 38298 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4314	4326	4314
q2	387	285	269	269
q3	2926	2674	2661	2661
q4	1952	1652	1658	1652
q5	5429	5369	5400	5369
q6	227	133	133	133
q7	2053	1741	1749	1741
q8	3205	3345	3343	3343
q9	8439	8379	8347	8347
q10	3464	3219	3211	3211
q11	575	512	495	495
q12	799	601	626	601
q13	10849	3086	3080	3080
q14	313	278	276	276
q15	516	481	490	481
q16	593	578	568	568
q17	1792	1498	1476	1476
q18	7816	7401	7421	7401
q19	1655	1537	1509	1509
q20	2063	1847	1826	1826
q21	5540	5390	5276	5276
q22	1092	995	1020	995
Total cold run time: 66030 ms
Total hot run time: 55024 ms

doris-robot · 2024-09-03T02:34:29Z

TPC-DS: Total hot run time: 188038 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

query1	912	368	374	368
query2	6456	2073	1963	1963
query3	6650	203	227	203
query4	29222	23200	23347	23200
query5	4174	493	497	493
query6	255	161	160	160
query7	4574	284	283	283
query8	255	208	229	208
query9	8565	2453	2456	2453
query10	446	278	288	278
query11	17007	15119	15121	15119
query12	150	103	98	98
query13	1623	370	370	370
query14	9547	7398	7022	7022
query15	253	169	169	169
query16	7485	473	461	461
query17	1573	567	539	539
query18	1987	315	284	284
query19	299	147	151	147
query20	122	109	106	106
query21	205	106	103	103
query22	4317	4305	4209	4209
query23	34177	33733	33321	33321
query24	10941	2874	2854	2854
query25	606	407	390	390
query26	1126	153	149	149
query27	2336	279	277	277
query28	7353	2059	2030	2030
query29	748	414	404	404
query30	312	153	154	153
query31	987	750	757	750
query32	94	54	52	52
query33	753	286	281	281
query34	968	479	479	479
query35	870	733	716	716
query36	1111	936	941	936
query37	150	91	97	91
query38	3996	3865	3869	3865
query39	1437	1393	1406	1393
query40	195	115	112	112
query41	47	46	43	43
query42	116	97	96	96
query43	507	487	485	485
query44	1186	746	759	746
query45	198	164	166	164
query46	1092	758	758	758
query47	1896	1792	1799	1792
query48	371	292	292	292
query49	1097	419	420	419
query50	823	408	411	408
query51	6877	6935	6895	6895
query52	95	87	87	87
query53	253	186	186	186
query54	883	460	451	451
query55	79	75	76	75
query56	271	256	260	256
query57	1173	1083	1067	1067
query58	240	227	251	227
query59	3015	2843	2808	2808
query60	286	264	263	263
query61	99	99	106	99
query62	819	611	655	611
query63	218	180	189	180
query64	4161	686	720	686
query65	3222	3293	3152	3152
query66	1442	362	345	345
query67	15521	15303	15362	15303
query68	3574	594	563	563
query69	416	277	274	274
query70	1204	1139	1126	1126
query71	331	278	279	278
query72	6500	4133	4056	4056
query73	745	329	331	329
query74	9158	8786	8766	8766
query75	3418	2693	2708	2693
query76	1911	951	1012	951
query77	481	327	320	320
query78	9813	9037	9498	9037
query79	1092	531	524	524
query80	800	510	509	509
query81	576	237	233	233
query82	1250	143	147	143
query83	242	152	153	152
query84	228	77	86	77
query85	1040	289	322	289
query86	311	299	275	275
query87	4367	4274	4268	4268
query88	2871	2307	2316	2307
query89	399	291	282	282
query90	1789	185	185	185
query91	124	99	100	99
query92	61	47	47	47
query93	1045	547	529	529
query94	594	282	287	282
query95	350	250	255	250
query96	580	258	257	257
query97	3203	3110	3122	3110
query98	213	207	198	198
query99	1623	1293	1246	1246
Total cold run time: 280533 ms
Total hot run time: 188038 ms

yiguolei · 2024-09-03T02:35:32Z

regression-test/suites/datatype_p0/decimalv3/test_decimal256_cast.groovy

+    """
+    test {
+        sql """
+            select cast(v1 as float) from dec256cast_to_float;


also add cast for literal and test fold constant is true or false

yiguolei · 2024-09-03T02:36:50Z

regression-test/suites/datatype_p0/decimalv3/test_decimal256_cast.groovy

@@ -41,4 +41,29 @@ suite("test_decimal256_cast") {
        select cast('0.000000000000000000000000000000000000000000000000000000000000000000000012345678901' as decimalv3(76,0));
    """

+    sql """
+        drop table  if exists dec256cast_to_float;


The previous cast test only test const literal, should also add some test to insert the data to a table and cast them during select.

doris-robot · 2024-09-03T02:40:03Z

ClickBench: Total hot run time: 33.01 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 843dd58db541fc233a99674ac094c0e27bdf1cc5, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.05
query4	1.67	0.08	0.07
query5	0.50	0.51	0.48
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.55	0.49	0.48
query10	0.56	0.55	0.54
query11	0.15	0.12	0.11
query12	0.15	0.13	0.12
query13	0.61	0.59	0.59
query14	2.11	2.04	2.11
query15	0.89	0.83	0.82
query16	0.36	0.40	0.38
query17	0.97	1.04	1.06
query18	0.21	0.21	0.20
query19	1.89	1.80	1.73
query20	0.01	0.01	0.02
query21	15.39	0.68	0.67
query22	4.26	6.22	2.89
query23	18.29	1.40	1.25
query24	2.12	0.21	0.22
query25	0.15	0.08	0.07
query26	0.27	0.18	0.17
query27	0.08	0.08	0.09
query28	13.18	1.02	1.00
query29	12.63	3.43	3.39
query30	0.24	0.06	0.05
query31	2.88	0.40	0.39
query32	3.26	0.47	0.47
query33	2.95	2.98	3.05
query34	16.99	4.43	4.40
query35	4.51	4.46	4.42
query36	0.67	0.46	0.48
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.79 s
Total hot run time: 33.01 s

yiguolei · 2024-09-03T02:45:42Z

regression-test/suites/datatype_p0/decimalv3/test_decimal256_cast.groovy

@@ -41,4 +41,29 @@ suite("test_decimal256_cast") {
        select cast('0.000000000000000000000000000000000000000000000000000000000000000000000012345678901' as decimalv3(76,0));
    """

+    sql """


字面常量的测试：包括打开常量折叠，关闭常量折叠
变量的测试：把数据插入到表中，然后select 执行函数
cast：别的类型，到decimal； decimal 到别的类型。
不论是字面量还是变量，都要测试异常的值。

…hen converting from decimal to float

jacktengg · 2024-09-03T08:28:02Z

run buildall

github-actions · 2024-09-03T08:34:13Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-03T08:34:17Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-03T09:40:29Z

TPC-H: Total hot run time: 38641 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e778180ad09715731d6cbf2af6cc488322f7e50b, data reload: false

------ Round 1 ----------------------------------
q1	17799	4703	4471	4471
q2	2590	183	176	176
q3	10877	1281	1195	1195
q4	10519	755	780	755
q5	8179	2964	2852	2852
q6	238	140	145	140
q7	971	631	609	609
q8	9673	2102	2105	2102
q9	7236	6545	7408	6545
q10	7013	2201	2270	2201
q11	483	244	237	237
q12	402	221	226	221
q13	18010	3104	3082	3082
q14	273	230	234	230
q15	524	490	489	489
q16	584	519	515	515
q17	988	717	682	682
q18	7490	6811	6811	6811
q19	1389	988	1046	988
q20	688	341	341	341
q21	4289	2983	3014	2983
q22	1113	1027	1016	1016
Total cold run time: 111328 ms
Total hot run time: 38641 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4361	4464	4292	4292
q2	385	279	277	277
q3	2936	2684	2674	2674
q4	1921	1659	1714	1659
q5	5402	5415	5437	5415
q6	219	129	131	129
q7	2149	1743	1793	1743
q8	3234	3371	3386	3371
q9	8502	8485	8403	8403
q10	3453	3242	3217	3217
q11	609	484	488	484
q12	821	633	637	633
q13	11208	3064	3075	3064
q14	304	278	278	278
q15	523	478	494	478
q16	650	585	578	578
q17	1787	1498	1477	1477
q18	7805	7604	7410	7410
q19	1681	1607	1608	1607
q20	2058	1855	1821	1821
q21	5555	5321	5219	5219
q22	1145	1046	1040	1040
Total cold run time: 66708 ms
Total hot run time: 55269 ms

doris-robot · 2024-09-03T09:52:17Z

TPC-DS: Total hot run time: 188229 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e778180ad09715731d6cbf2af6cc488322f7e50b, data reload: false

query1	919	387	370	370
query2	6458	1966	2011	1966
query3	6644	212	219	212
query4	34354	23144	23138	23138
query5	4181	495	485	485
query6	246	182	166	166
query7	4580	295	283	283
query8	243	203	198	198
query9	8477	2443	2420	2420
query10	440	280	263	263
query11	15715	15039	15072	15039
query12	147	99	98	98
query13	1637	372	371	371
query14	9633	7109	6723	6723
query15	235	168	169	168
query16	7931	458	455	455
query17	1598	592	539	539
query18	2060	279	285	279
query19	213	139	144	139
query20	119	110	109	109
query21	208	105	102	102
query22	4508	4022	4138	4022
query23	34038	33688	33482	33482
query24	11021	2836	2877	2836
query25	647	381	377	377
query26	1337	161	152	152
query27	2850	277	274	274
query28	7352	2041	2023	2023
query29	882	468	405	405
query30	313	159	152	152
query31	1001	771	775	771
query32	94	54	55	54
query33	759	289	287	287
query34	1009	475	492	475
query35	871	713	705	705
query36	1118	935	919	919
query37	165	93	90	90
query38	4119	3825	3958	3825
query39	1453	1409	1437	1409
query40	261	115	114	114
query41	46	43	43	43
query42	111	90	94	90
query43	530	459	468	459
query44	1227	732	733	732
query45	196	170	165	165
query46	1101	746	734	734
query47	1904	1804	1804	1804
query48	382	290	302	290
query49	1097	441	441	441
query50	840	408	405	405
query51	7071	6888	6910	6888
query52	100	87	89	87
query53	258	185	180	180
query54	1013	474	469	469
query55	74	78	73	73
query56	290	272	266	266
query57	1207	1054	1043	1043
query58	256	224	294	224
query59	3039	2833	2839	2833
query60	321	282	271	271
query61	128	122	123	122
query62	843	652	633	633
query63	226	187	179	179
query64	5429	766	726	726
query65	3519	3165	3161	3161
query66	1403	346	343	343
query67	15517	15504	15427	15427
query68	4472	563	547	547
query69	404	282	282	282
query70	1189	1142	1084	1084
query71	338	274	290	274
query72	6607	3910	4199	3910
query73	756	326	327	326
query74	9323	8816	8948	8816
query75	3455	2684	2814	2684
query76	2287	998	967	967
query77	485	300	311	300
query78	11582	9775	9870	9775
query79	1571	535	520	520
query80	946	500	506	500
query81	588	230	232	230
query82	303	146	139	139
query83	265	150	168	150
query84	267	76	76	76
query85	701	280	276	276
query86	477	290	299	290
query87	4435	4390	4294	4294
query88	3391	2338	2340	2338
query89	373	286	274	274
query90	1829	186	188	186
query91	125	101	130	101
query92	65	47	47	47
query93	1061	529	523	523
query94	831	300	290	290
query95	351	249	248	248
query96	597	268	267	267
query97	3181	3096	3040	3040
query98	232	197	199	197
query99	1758	1308	1295	1295
Total cold run time: 292209 ms
Total hot run time: 188229 ms

doris-robot · 2024-09-03T09:57:51Z

ClickBench: Total hot run time: 32.16 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e778180ad09715731d6cbf2af6cc488322f7e50b, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.68	0.08	0.08
query5	0.51	0.49	0.48
query6	1.13	0.73	0.73
query7	0.01	0.01	0.01
query8	0.06	0.05	0.05
query9	0.54	0.47	0.49
query10	0.53	0.53	0.53
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.58	0.58
query14	2.10	2.02	2.09
query15	0.84	0.81	0.82
query16	0.37	0.35	0.38
query17	1.03	1.03	0.97
query18	0.21	0.20	0.20
query19	1.89	1.76	1.71
query20	0.01	0.01	0.02
query21	15.43	0.67	0.66
query22	4.33	7.08	2.20
query23	18.28	1.42	1.30
query24	2.09	0.22	0.22
query25	0.17	0.08	0.08
query26	0.28	0.18	0.18
query27	0.08	0.09	0.08
query28	13.28	1.01	0.99
query29	12.62	3.32	3.28
query30	0.25	0.05	0.06
query31	2.89	0.39	0.39
query32	3.26	0.48	0.47
query33	2.97	3.56	3.02
query34	17.21	4.38	4.39
query35	4.44	4.41	4.44
query36	0.67	0.50	0.48
query37	0.19	0.15	0.15
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 111.18 s
Total hot run time: 32.16 s

github-actions · 2024-09-04T02:29:42Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-04T02:29:45Z

PR approved by anyone and no changes requested.

zclllyybb

LGTM

…hen converting from decimal to float (apache#40290)

…hen converting from decimal to float (#40290) (#41007) ## Proposed changes Issue Number: close #xxx BP #40290

…hen converting from decimal to float (#40290) (#41009) ## Proposed changes Issue Number: close #xxx BP #40290

jacktengg force-pushed the fix-0902 branch from 22db537 to 843dd58 Compare September 2, 2024 16:50

yiguolei reviewed Sep 3, 2024

View reviewed changes

jacktengg force-pushed the fix-0902 branch from 843dd58 to f5a586d Compare September 3, 2024 08:27

jacktengg added 2 commits September 3, 2024 16:27

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

e7e1863

…hen converting from decimal to float

improve test case

e778180

jacktengg force-pushed the fix-0902 branch from f5a586d to e778180 Compare September 3, 2024 08:27

yiguolei approved these changes Sep 4, 2024

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 4, 2024

yiguolei added dev/2.1.x dev/3.0.x labels Sep 4, 2024

zclllyybb approved these changes Sep 4, 2024

View reviewed changes

yiguolei merged commit 2fd7593 into apache:master Sep 4, 2024
25 of 28 checks passed

jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 19, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

5745658

…hen converting from decimal to float (apache#40290)

jacktengg mentioned this pull request Sep 19, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float (#40290) #41007

Merged

jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 19, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

38c5d60

…hen converting from decimal to float (apache#40290)

jacktengg mentioned this pull request Sep 19, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float (#40290) #41009

Merged

jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 19, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

800e197

…hen converting from decimal to float (apache#40290)

jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 20, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

f4ca2db

…hen converting from decimal to float (apache#40290)

yiguolei pushed a commit that referenced this pull request Sep 20, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

6539c8f

…hen converting from decimal to float (#40290) (#41007) ## Proposed changes Issue Number: close #xxx BP #40290

yiguolei added dev/2.1.7-merged and removed dev/2.1.x labels Sep 20, 2024

yiguolei pushed a commit that referenced this pull request Sep 27, 2024

[fix](decimal) throw overflow exception if result is NaN of Infinit w…

1b76fcc

…hen converting from decimal to float (#40290) (#41009) ## Proposed changes Issue Number: close #xxx BP #40290

yiguolei added dev/3.0.2-merged and removed dev/3.0.x labels Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float #40290

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float #40290

jacktengg commented Sep 2, 2024 •

edited

Loading

doris-robot commented Sep 2, 2024

jacktengg commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

jacktengg commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

yiguolei Sep 3, 2024

yiguolei Sep 3, 2024

doris-robot commented Sep 3, 2024

yiguolei Sep 3, 2024

jacktengg commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

zclllyybb left a comment

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float #40290

[fix](decimal) throw overflow exception if result is NaN of Infinit when converting from decimal to float #40290

Conversation

jacktengg commented Sep 2, 2024 • edited Loading

Proposed changes

doris-robot commented Sep 2, 2024

jacktengg commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

jacktengg commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

yiguolei Sep 3, 2024

Choose a reason for hiding this comment

yiguolei Sep 3, 2024

Choose a reason for hiding this comment

doris-robot commented Sep 3, 2024

yiguolei Sep 3, 2024

Choose a reason for hiding this comment

jacktengg commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

doris-robot commented Sep 3, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

zclllyybb left a comment

Choose a reason for hiding this comment

jacktengg commented Sep 2, 2024 •

edited

Loading