Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building Docker image error #390

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fix building Docker image error #390

merged 1 commit into from
Dec 5, 2018

Conversation

uestctxq
Copy link
Contributor

@uestctxq uestctxq commented Dec 5, 2018

imay
imay requested changes Dec 5, 2018
View reviewed changes
env.sh
@@ -31,23 +31,6 @@ if [[ -z ${DORIS_THIRDPARTY} ]]; then
export DORIS_THIRDPARTY=${DORIS_HOME}/thirdparty
fi

# check java version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check Java and maven version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen the build script, the check java also in build.sh. Why you build jdk after check java in the build-thirdparty.sh? And I have test the build after I delete this. You can test it in your environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAVA_HOME can be set by user in his environment, and not everyone use thirdparty's JDK as his JAVA_HOME.
So, we need to check java's version to make sure it can work with our project.

@uestctxq uestctxq force-pushed the fix-docker-build-error branch from a643268 to 9df7971 Compare December 5, 2018 10:18
lide-reed
lide-reed approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 5f9f016 into apache:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lide-reed lide-reed lide-reed approved these changes

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uestctxq @imay @lide-reed