Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](http) fix http url with incorrect character notation #38420

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[fix](http) fix http url with incorrect character notation #38420

merged 1 commit into from
Aug 15, 2024

Conversation

csun5285
Copy link
Contributor

Proposed changes

Single replica load, compaction, cloning or others, may result in a 404 error if the parameter name contains illegal symbols

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39130 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 61f1c83dcbe612b379f59d4e4eaf0a51ed8db608, data reload: false

------ Round 1 ----------------------------------
q1	17674	4339	4241	4241
q2	2007	202	200	200
q3	10435	1173	1117	1117
q4	10124	743	760	743
q5	7528	2725	2677	2677
q6	218	137	136	136
q7	950	594	591	591
q8	9228	1897	1903	1897
q9	8715	6522	6536	6522
q10	8697	3829	3773	3773
q11	457	248	254	248
q12	390	229	218	218
q13	17882	2992	2958	2958
q14	280	230	249	230
q15	515	485	500	485
q16	498	398	382	382
q17	950	686	729	686
q18	7984	7451	7278	7278
q19	7075	967	1075	967
q20	676	329	343	329
q21	4969	3168	3882	3168
q22	349	284	285	284
Total cold run time: 117601 ms
Total hot run time: 39130 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4481	4255	4311	4255
q2	374	262	260	260
q3	3003	2839	2891	2839
q4	1995	1716	1677	1677
q5	5629	5548	5453	5453
q6	222	131	131	131
q7	2187	1839	1877	1839
q8	3298	3434	3455	3434
q9	8866	8830	8945	8830
q10	4171	3931	3848	3848
q11	589	493	506	493
q12	813	646	655	646
q13	16276	3206	3204	3204
q14	332	306	305	305
q15	529	492	485	485
q16	492	426	436	426
q17	1819	1502	1508	1502
q18	8155	7913	7842	7842
q19	3582	1605	1435	1435
q20	2158	1899	1884	1884
q21	7546	4911	4783	4783
q22	574	517	514	514
Total cold run time: 77091 ms
Total hot run time: 56085 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172476 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 61f1c83dcbe612b379f59d4e4eaf0a51ed8db608, data reload: false

query1	917	371	364	364
query2	6964	1989	1851	1851
query3	8985	228	229	228
query4	24234	17647	17253	17253
query5	3679	500	476	476
query6	249	195	158	158
query7	4587	298	278	278
query8	236	195	191	191
query9	8447	2441	2431	2431
query10	441	287	287	287
query11	11742	10168	10209	10168
query12	120	88	84	84
query13	1636	367	371	367
query14	10288	6848	7922	6848
query15	262	163	161	161
query16	7707	539	489	489
query17	1582	531	565	531
query18	1554	281	280	280
query19	190	137	139	137
query20	98	88	88	88
query21	211	98	101	98
query22	4221	4015	4050	4015
query23	34432	33863	33689	33689
query24	10629	2902	2951	2902
query25	592	391	398	391
query26	715	149	152	149
query27	2321	277	277	277
query28	6041	2074	2061	2061
query29	689	457	456	456
query30	254	153	160	153
query31	988	774	740	740
query32	95	54	58	54
query33	779	361	329	329
query34	918	486	485	485
query35	890	742	784	742
query36	1132	978	956	956
query37	140	83	83	83
query38	2901	2899	2851	2851
query39	911	861	868	861
query40	214	119	117	117
query41	47	44	44	44
query42	109	97	99	97
query43	505	462	477	462
query44	1175	714	714	714
query45	205	178	174	174
query46	1091	726	741	726
query47	1855	1737	1761	1737
query48	364	292	287	287
query49	842	430	415	415
query50	800	405	404	404
query51	6808	6766	6683	6683
query52	91	94	83	83
query53	261	184	184	184
query54	916	437	433	433
query55	77	72	75	72
query56	288	278	282	278
query57	1124	1064	1046	1046
query58	243	250	285	250
query59	2848	2576	2516	2516
query60	314	280	286	280
query61	96	92	93	92
query62	786	661	641	641
query63	210	174	177	174
query64	9183	2342	1810	1810
query65	3199	3077	3108	3077
query66	745	341	331	331
query67	15402	14890	14860	14860
query68	4577	539	545	539
query69	436	294	303	294
query70	1238	1048	1136	1048
query71	407	269	266	266
query72	7131	5594	5744	5594
query73	737	327	332	327
query74	6175	5687	5620	5620
query75	3348	2633	2690	2633
query76	2712	958	921	921
query77	443	308	319	308
query78	9666	9064	8880	8880
query79	2678	512	512	512
query80	2314	484	472	472
query81	596	224	215	215
query82	921	137	136	136
query83	327	176	173	173
query84	259	85	76	76
query85	1252	314	296	296
query86	467	284	309	284
query87	3178	3084	3072	3072
query88	3809	2471	2479	2471
query89	395	285	283	283
query90	1707	195	189	189
query91	125	98	98	98
query92	60	48	49	48
query93	2586	523	525	523
query94	820	293	262	262
query95	351	257	261	257
query96	605	288	272	272
query97	3200	2988	3040	2988
query98	220	203	213	203
query99	1645	1267	1273	1267
Total cold run time: 276960 ms
Total hot run time: 172476 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 61f1c83dcbe612b379f59d4e4eaf0a51ed8db608, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.50	0.49	0.49
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.56	0.48	0.49
query10	0.54	0.55	0.55
query11	0.15	0.11	0.12
query12	0.14	0.12	0.13
query13	0.59	0.59	0.58
query14	0.77	0.78	0.78
query15	0.84	0.80	0.81
query16	0.37	0.37	0.36
query17	1.05	1.02	1.08
query18	0.22	0.21	0.21
query19	1.81	1.81	1.68
query20	0.01	0.01	0.01
query21	15.41	0.75	0.65
query22	4.65	6.72	2.36
query23	18.24	1.43	1.21
query24	2.20	0.24	0.21
query25	0.16	0.09	0.09
query26	0.29	0.21	0.20
query27	0.46	0.24	0.23
query28	13.24	1.02	1.00
query29	12.60	3.31	3.25
query30	0.24	0.06	0.05
query31	2.87	0.39	0.39
query32	3.27	0.47	0.49
query33	2.90	2.91	2.94
query34	17.04	4.35	4.42
query35	4.42	4.44	4.48
query36	0.67	0.46	0.47
query37	0.19	0.15	0.15
query38	0.17	0.16	0.16
query39	0.04	0.04	0.03
query40	0.14	0.12	0.12
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.18 s
Total hot run time: 31.01 s

@csun5285 csun5285 force-pushed the test_single_replica_load branch from 61f1c83 to 219786b Compare August 6, 2024 08:43
@csun5285
Copy link
Contributor Author

csun5285 commented Aug 6, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41962 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 219786b5121bcd9c32e488f2df840555ddf4d4f0, data reload: false

------ Round 1 ----------------------------------
q1	17725	4884	4100	4100
q2	2026	211	204	204
q3	10566	1357	1391	1357
q4	10267	883	937	883
q5	7584	3020	2997	2997
q6	229	142	139	139
q7	1081	627	622	622
q8	9469	1834	1967	1834
q9	8506	6620	6608	6608
q10	8748	3855	3865	3855
q11	427	250	250	250
q12	419	231	230	230
q13	17778	2953	2939	2939
q14	278	243	245	243
q15	530	489	505	489
q16	503	402	398	398
q17	978	950	930	930
q18	8182	7373	7262	7262
q19	1612	1230	1227	1227
q20	574	327	331	327
q21	5461	4859	4785	4785
q22	354	289	283	283
Total cold run time: 113297 ms
Total hot run time: 41962 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4060	4002	3989	3989
q2	331	219	220	219
q3	3036	3110	3166	3110
q4	2046	2037	1982	1982
q5	5691	5475	5457	5457
q6	219	134	133	133
q7	2149	1828	1825	1825
q8	3333	3352	3409	3352
q9	8764	8782	8786	8782
q10	3975	4030	4000	4000
q11	565	496	475	475
q12	772	628	616	616
q13	15631	3145	3171	3145
q14	308	283	276	276
q15	540	483	480	480
q16	470	422	419	419
q17	1793	1770	1725	1725
q18	8318	7775	7804	7775
q19	1780	1757	1752	1752
q20	2094	1852	1861	1852
q21	5802	5583	5565	5565
q22	536	460	481	460
Total cold run time: 72213 ms
Total hot run time: 57389 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170134 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 219786b5121bcd9c32e488f2df840555ddf4d4f0, data reload: false

query1	922	391	376	376
query2	6481	1771	1720	1720
query3	6653	211	217	211
query4	20223	17541	17444	17444
query5	3679	535	533	533
query6	290	192	200	192
query7	4593	315	296	296
query8	256	199	196	196
query9	8523	2430	2397	2397
query10	426	286	275	275
query11	10443	10114	10056	10056
query12	127	95	88	88
query13	1640	379	375	375
query14	8627	6962	6520	6520
query15	206	165	174	165
query16	6974	490	467	467
query17	969	574	564	564
query18	1979	281	278	278
query19	186	146	142	142
query20	93	85	85	85
query21	201	100	98	98
query22	4106	3969	3998	3969
query23	34060	33663	33593	33593
query24	10386	3149	3147	3147
query25	697	418	416	416
query26	1829	160	151	151
query27	3030	281	280	280
query28	7380	2070	2045	2045
query29	1295	452	436	436
query30	236	155	157	155
query31	943	803	758	758
query32	99	55	57	55
query33	681	331	350	331
query34	921	486	508	486
query35	851	797	797	797
query36	1088	911	902	902
query37	299	90	86	86
query38	3039	2893	2857	2857
query39	858	808	821	808
query40	254	115	113	113
query41	45	45	43	43
query42	131	102	108	102
query43	484	419	433	419
query44	1194	733	732	732
query45	215	177	178	177
query46	1091	839	826	826
query47	1813	1713	1699	1699
query48	365	292	293	292
query49	956	436	435	435
query50	895	445	443	443
query51	6841	6784	6665	6665
query52	106	93	88	88
query53	264	191	187	187
query54	645	463	458	458
query55	75	75	108	75
query56	285	279	264	264
query57	1130	1043	1063	1043
query58	282	294	282	282
query59	2777	2325	2313	2313
query60	298	286	282	282
query61	102	98	96	96
query62	898	660	651	651
query63	208	183	184	183
query64	5588	1929	1926	1926
query65	3195	3209	3102	3102
query66	1312	341	336	336
query67	15181	14872	14684	14684
query68	4279	567	570	567
query69	441	296	305	296
query70	1132	1065	1066	1065
query71	416	301	298	298
query72	7090	2700	2506	2506
query73	748	332	337	332
query74	6126	5696	5709	5696
query75	3372	2749	2750	2749
query76	2099	1220	1254	1220
query77	443	317	321	317
query78	9438	8960	8953	8953
query79	1481	537	545	537
query80	997	514	532	514
query81	588	233	226	226
query82	996	151	131	131
query83	246	173	178	173
query84	266	85	81	81
query85	1243	383	328	328
query86	403	284	324	284
query87	3300	3119	3098	3098
query88	2926	2411	2429	2411
query89	403	296	300	296
query90	1701	197	196	196
query91	124	103	100	100
query92	59	51	52	51
query93	1412	630	619	619
query94	786	291	303	291
query95	407	280	286	280
query96	594	280	282	280
query97	3233	3093	3071	3071
query98	273	200	209	200
query99	1633	1302	1302	1302
Total cold run time: 260574 ms
Total hot run time: 170134 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.09 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 219786b5121bcd9c32e488f2df840555ddf4d4f0, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.05	0.04
query3	0.23	0.05	0.04
query4	1.68	0.07	0.05
query5	0.49	0.49	0.50
query6	1.13	0.71	0.70
query7	0.03	0.01	0.01
query8	0.06	0.04	0.04
query9	0.56	0.51	0.53
query10	0.58	0.59	0.57
query11	0.15	0.11	0.11
query12	0.16	0.13	0.13
query13	0.60	0.61	0.60
query14	0.78	0.81	0.79
query15	0.90	0.87	0.87
query16	0.36	0.36	0.36
query17	1.01	1.00	0.99
query18	0.22	0.21	0.21
query19	1.85	1.76	1.76
query20	0.02	0.01	0.01
query21	15.38	0.76	0.67
query22	4.13	7.83	1.29
query23	18.06	1.48	1.31
query24	2.23	0.24	0.23
query25	0.18	0.08	0.08
query26	0.32	0.21	0.23
query27	0.46	0.24	0.24
query28	13.16	1.02	0.98
query29	12.56	3.29	3.29
query30	0.27	0.06	0.05
query31	2.89	0.42	0.41
query32	3.22	0.49	0.48
query33	2.99	2.97	2.93
query34	15.41	4.26	4.28
query35	4.32	4.27	4.33
query36	0.67	0.50	0.48
query37	0.20	0.17	0.16
query38	0.17	0.15	0.14
query39	0.04	0.04	0.04
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.06	0.05
query43	0.05	0.04	0.03
Total cold run time: 107.96 s
Total hot run time: 30.09 s

xiaokang
xiaokang approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit b2b15d3 into apache:master Aug 15, 2024
28 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@csun5285 @dataroaring
[fix](http) fix http url with incorrect character notation (#38420)
1011a2b 
Single replica load, compaction, cloning or others, may result in a 404
error if the parameter name contains illegal symbols
@csun5285 csun5285 mentioned this pull request Aug 18, 2024
Merged
airborne12 pushed a commit that referenced this pull request Aug 19, 2024
@csun5285
[fix](http) fix http url with incorrect character notation (#38420) (#…
fb17f20 
…39535)

## Proposed changes

pick from master #38420
@qidaye qidaye removed the dev/2.1.x label Aug 21, 2024
@xiaokang xiaokang removed the doing label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csun5285 @doris-robot @xiaokang @eldenmoon @qidaye @dataroaring