Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](debug_point) Add reached_limit_early debug point #38127

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[fix](debug_point) Add reached_limit_early debug point #38127

merged 1 commit into from
Jul 22, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 19, 2024

Proposed changes

This debug point has a parameter named op_name used to specify the operator's name.

And remove the unused function reached_limit()

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@mrhhsg mrhhsg force-pushed the add_debug_point branch from 215d45b to f3ba057 Compare July 19, 2024 08:05
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 19, 2024
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 19, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg force-pushed the add_debug_point branch from f3ba057 to d793863 Compare July 19, 2024 08:22
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 19, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40520 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d79386373005754576c29d933eb20e32d5f33bcf, data reload: false

------ Round 1 ----------------------------------
q1	18181	4772	4429	4429
q2	2893	200	195	195
q3	11403	1187	1201	1187
q4	10335	791	771	771
q5	7831	2774	2774	2774
q6	232	145	147	145
q7	982	640	635	635
q8	9280	2102	2130	2102
q9	8806	6600	6585	6585
q10	8700	3795	3790	3790
q11	473	245	254	245
q12	405	237	226	226
q13	18832	2974	3012	2974
q14	286	235	240	235
q15	525	483	497	483
q16	505	402	385	385
q17	990	679	679	679
q18	8159	7528	7468	7468
q19	2278	1488	1407	1407
q20	705	317	348	317
q21	5121	3209	3312	3209
q22	363	279	291	279
Total cold run time: 117285 ms
Total hot run time: 40520 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4373	4301	4302	4301
q2	372	264	272	264
q3	2991	2769	2751	2751
q4	1933	1665	1599	1599
q5	5337	5318	5322	5318
q6	225	132	135	132
q7	2136	1753	1714	1714
q8	3213	3434	3334	3334
q9	8463	8420	8421	8420
q10	3880	3740	3686	3686
q11	589	497	480	480
q12	777	581	599	581
q13	16276	2998	2992	2992
q14	300	285	265	265
q15	524	476	479	476
q16	485	418	418	418
q17	1763	1504	1488	1488
q18	7626	7528	7352	7352
q19	2157	1597	1512	1512
q20	2002	1785	1800	1785
q21	4920	4815	4824	4815
q22	587	489	479	479
Total cold run time: 70929 ms
Total hot run time: 54162 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172726 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d79386373005754576c29d933eb20e32d5f33bcf, data reload: false

query1	909	376	368	368
query2	6443	1848	1775	1775
query3	6665	209	218	209
query4	28307	17178	17303	17178
query5	4208	487	494	487
query6	291	209	166	166
query7	4607	303	298	298
query8	239	196	188	188
query9	8388	2452	2433	2433
query10	433	280	269	269
query11	10443	9907	10094	9907
query12	138	84	82	82
query13	1633	369	361	361
query14	10332	8172	7426	7426
query15	222	164	173	164
query16	7695	481	525	481
query17	1583	559	562	559
query18	1931	292	285	285
query19	204	161	162	161
query20	137	84	86	84
query21	207	130	127	127
query22	4315	4058	4143	4058
query23	33564	33116	33035	33035
query24	11798	2802	2880	2802
query25	641	369	396	369
query26	1787	148	149	148
query27	2899	275	276	275
query28	7482	2028	1995	1995
query29	1052	626	613	613
query30	284	148	153	148
query31	973	722	737	722
query32	94	55	58	55
query33	771	332	337	332
query34	908	478	504	478
query35	867	742	772	742
query36	1102	970	954	954
query37	144	82	79	79
query38	2906	2757	2784	2757
query39	876	808	810	808
query40	290	124	121	121
query41	45	45	42	42
query42	127	97	100	97
query43	513	456	463	456
query44	1190	743	742	742
query45	192	164	164	164
query46	1106	745	753	745
query47	1844	1741	1742	1741
query48	374	297	298	297
query49	1166	425	415	415
query50	782	399	399	399
query51	6893	6818	6689	6689
query52	107	97	100	97
query53	369	293	298	293
query54	979	446	453	446
query55	78	73	74	73
query56	303	279	303	279
query57	1163	1046	1050	1046
query58	258	259	249	249
query59	2772	2546	2660	2546
query60	309	288	293	288
query61	98	92	92	92
query62	823	648	627	627
query63	331	305	303	303
query64	10515	2280	1697	1697
query65	3179	3128	3109	3109
query66	1418	354	334	334
query67	15341	14923	14978	14923
query68	4562	551	563	551
query69	467	344	339	339
query70	1168	1136	1075	1075
query71	384	281	281	281
query72	6800	5704	5790	5704
query73	766	326	324	324
query74	6037	5744	5646	5646
query75	3381	2743	2702	2702
query76	2847	1004	981	981
query77	468	325	313	313
query78	9500	9072	8969	8969
query79	2289	517	534	517
query80	2049	471	470	470
query81	600	222	216	216
query82	899	143	136	136
query83	290	169	230	169
query84	277	85	91	85
query85	2128	309	297	297
query86	496	331	313	313
query87	3309	3092	3068	3068
query88	4080	2373	2376	2373
query89	483	394	388	388
query90	1839	199	191	191
query91	125	99	98	98
query92	71	51	50	50
query93	2531	512	500	500
query94	1272	305	297	297
query95	409	310	313	310
query96	611	271	270	270
query97	3211	2977	3080	2977
query98	222	199	201	199
query99	1778	1277	1229	1229
Total cold run time: 285392 ms
Total hot run time: 172726 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 30.42 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d79386373005754576c29d933eb20e32d5f33bcf, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.08	0.07
query5	0.50	0.48	0.50
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.55	0.48	0.47
query10	0.54	0.55	0.55
query11	0.15	0.11	0.12
query12	0.15	0.14	0.12
query13	0.61	0.60	0.59
query14	0.79	0.78	0.77
query15	0.87	0.81	0.81
query16	0.34	0.37	0.36
query17	1.05	1.04	0.95
query18	0.25	0.22	0.22
query19	1.90	1.82	1.73
query20	0.01	0.01	0.01
query21	15.40	0.74	0.66
query22	4.61	6.66	1.84
query23	18.28	1.32	1.25
query24	2.09	0.22	0.23
query25	0.16	0.09	0.09
query26	0.29	0.21	0.21
query27	0.45	0.24	0.22
query28	13.33	1.01	1.00
query29	12.61	3.28	3.26
query30	0.25	0.07	0.06
query31	2.87	0.38	0.38
query32	3.29	0.49	0.47
query33	2.88	2.90	2.83
query34	16.90	4.35	4.34
query35	4.44	4.47	4.45
query36	0.64	0.50	0.46
query37	0.19	0.15	0.16
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.09	0.04	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.15 s
Total hot run time: 30.42 s

@yiguolei yiguolei merged commit c01858f into apache:master Jul 22, 2024
26 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@mrhhsg @dataroaring
[fix](debug_point) Add reached_limit_early debug point (#38127)
30f0d69 
## Proposed changes

This debug point has a parameter named `op_name` used to specify the
operator's name.

And remove the unused function `reached_limit()`
@mrhhsg mrhhsg mentioned this pull request Jul 24, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
@mrhhsg
[fix](debug_point) Add debug point:reached_limit_early & return_empty…
4288f09 
…_block (#38328)

## Proposed changes

pick #38127 and #37629
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@jacktengg jacktengg jacktengg approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrhhsg @doris-robot @yiguolei @jacktengg @dataroaring