Disable Bitmap or Hll type in keys or in values with incorrect agg-type #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link issue like this: |
morningman
requested changes
Jun 4, 2020
Done. |
morningman
requested changes
Jun 4, 2020
| primitiveTypeList.add(PrimitiveType.HLL); | ||
| compatibilityMap.put(HLL_UNION, EnumSet.copyOf(primitiveTypeList)); | ||
|
|
||
| primitiveTypeList.clear(); | ||
|
|
||
| primitiveTypeList.add(PrimitiveType.BITMAP); |
There was a problem hiding this comment.
Why remove the primitiveTypeList.clear();.
Now, the BITMAP_UNION is compatible with both BITMAP and HLL?
There was a problem hiding this comment.
By mistake.
Thanks for reminding.
imay
reviewed
Jun 5, 2020
keep code style Co-authored-by: Zhao Chun <buaa.zhaoc@gmail.com>
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 7, 2020
…pe (apache#3768) Bitmap and Hll type can not be used with incorrect aggregate functions, which will cause to BE crush. Add some logical checks in FE's ColumnDef#analyze to avoid creating tables or changing schemas incorrectly. Keys never be bitmap or hll type values with bitmap or hll type have to be associated with bitmap_union or hll_union
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
…pe (apache#3768) Bitmap and Hll type can not be used with incorrect aggregate functions, which will cause to BE crush. Add some logical checks in FE's ColumnDef#analyze to avoid creating tables or changing schemas incorrectly. Keys never be bitmap or hll type values with bitmap or hll type have to be associated with bitmap_union or hll_union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitmap and Hll type can not be used with incorrect aggregate functions, which will cause to BE crush.
Add some logical checks in FE's ColumnDef#analyze to avoid creating tables or changing schemas incorrectly.