Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](regression) remove unique key duplicate cases #37601

Merged

Conversation

zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Jul 10, 2024

Proposed changes

Issue Number: close #xxx

  1. the suite tpch_unique_sql_zstd_p0 is almost duplicate with tpch_sf0.1_unique_p1 except for zstd, but zstd has a lot of cases can cover, we can remove tpch_unique_sql_zstd_p0 to improve p0 pipeline execution time
  2. the suite ssb_unique_load_zstd_p0 is completely duplicate with unique_with_mow_p0/ssb_unique_load_zstd
  3. the suite ssb_unique_sql_zstd_p0 is completely duplicate with unique_with_mow_p0/ssb_unique_sql_zstd

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 10, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhannngchen zhannngchen merged commit 63d5a85 into apache:master Jul 10, 2024
28 of 31 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
…7601)

1. the suite `tpch_unique_sql_zstd_p0` is almost duplicate with
`tpch_sf0.1_unique_p1` except for zstd, but zstd has a lot of cases can
cover, we can remove `tpch_unique_sql_zstd_p0` to improve p0 pipeline
execution time
2. the suite `ssb_unique_load_zstd_p0` is completely duplicate with
`unique_with_mow_p0/ssb_unique_load_zstd`
3. the suite `ssb_unique_sql_zstd_p0` is completely duplicate with
`unique_with_mow_p0/ssb_unique_sql_zstd`
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
1. the suite `tpch_unique_sql_zstd_p0` is almost duplicate with
`tpch_sf0.1_unique_p1` except for zstd, but zstd has a lot of cases can
cover, we can remove `tpch_unique_sql_zstd_p0` to improve p0 pipeline
execution time
2. the suite `ssb_unique_load_zstd_p0` is completely duplicate with
`unique_with_mow_p0/ssb_unique_load_zstd`
3. the suite `ssb_unique_sql_zstd_p0` is completely duplicate with
`unique_with_mow_p0/ssb_unique_sql_zstd`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants