Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](spill join) fix coredump of debug_string #36715

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[fix](spill join) fix coredump of debug_string #36715

merged 1 commit into from
Jun 24, 2024

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40621 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ba467343f6bdfa6edd7ebc563510473df4aaf6b5, data reload: false

------ Round 1 ----------------------------------
q1	17975	4907	4337	4337
q2	3107	201	199	199
q3	10835	1130	1109	1109
q4	10619	853	874	853
q5	7807	2945	2669	2669
q6	227	139	136	136
q7	975	637	616	616
q8	9560	2093	2065	2065
q9	8955	6493	6493	6493
q10	8992	3753	3717	3717
q11	449	240	235	235
q12	419	232	231	231
q13	18885	2979	2984	2979
q14	266	227	225	225
q15	519	466	490	466
q16	502	382	390	382
q17	966	622	687	622
q18	7934	7403	7424	7403
q19	5816	1487	1433	1433
q20	651	303	342	303
q21	4843	3810	3922	3810
q22	384	338	338	338
Total cold run time: 120686 ms
Total hot run time: 40621 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4374	4237	4691	4237
q2	378	269	274	269
q3	2966	2689	2711	2689
q4	1908	1559	1622	1559
q5	5263	5254	5274	5254
q6	216	125	127	125
q7	2088	1756	1747	1747
q8	3191	3341	3320	3320
q9	8357	8275	8364	8275
q10	3907	3623	3624	3623
q11	580	490	481	481
q12	773	597	613	597
q13	16377	3035	3055	3035
q14	280	263	254	254
q15	529	481	485	481
q16	467	426	422	422
q17	1762	1473	1458	1458
q18	7672	7518	7351	7351
q19	1721	1711	1539	1539
q20	1975	1764	1768	1764
q21	4863	4719	4682	4682
q22	617	538	554	538
Total cold run time: 70264 ms
Total hot run time: 53700 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173419 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ba467343f6bdfa6edd7ebc563510473df4aaf6b5, data reload: false

query1	911	373	378	373
query2	6471	2280	2202	2202
query3	6655	214	222	214
query4	19109	17360	17272	17272
query5	4172	482	464	464
query6	240	158	160	158
query7	4589	311	290	290
query8	324	290	274	274
query9	8613	2351	2338	2338
query10	611	302	291	291
query11	10456	10041	9965	9965
query12	144	92	83	83
query13	1631	367	369	367
query14	9282	7773	7717	7717
query15	254	190	196	190
query16	7937	296	313	296
query17	1840	538	520	520
query18	2013	286	272	272
query19	201	155	157	155
query20	93	79	82	79
query21	209	134	128	128
query22	4289	3979	3857	3857
query23	33642	32948	33133	32948
query24	11825	2909	2932	2909
query25	663	362	379	362
query26	1784	151	160	151
query27	2927	318	317	317
query28	7650	2065	2035	2035
query29	1051	626	599	599
query30	272	153	151	151
query31	948	714	759	714
query32	93	55	59	55
query33	775	285	280	280
query34	949	478	461	461
query35	719	630	640	630
query36	1077	930	952	930
query37	205	69	76	69
query38	2895	2702	2747	2702
query39	866	808	802	802
query40	280	129	128	128
query41	53	54	51	51
query42	121	97	103	97
query43	582	529	535	529
query44	1195	736	738	736
query45	208	166	165	165
query46	1084	735	715	715
query47	1835	1816	1781	1781
query48	375	308	313	308
query49	1196	421	414	414
query50	770	408	404	404
query51	6899	6943	6806	6806
query52	101	92	95	92
query53	362	291	290	290
query54	897	446	443	443
query55	79	76	78	76
query56	332	257	259	257
query57	1154	1078	1049	1049
query58	268	255	269	255
query59	3176	2973	3158	2973
query60	295	271	280	271
query61	95	94	91	91
query62	652	476	466	466
query63	323	298	304	298
query64	9867	2329	1720	1720
query65	3154	3149	3099	3099
query66	1371	335	349	335
query67	15425	15075	15274	15075
query68	4593	545	541	541
query69	454	309	318	309
query70	1122	1153	1146	1146
query71	388	271	269	269
query72	7173	5466	5810	5466
query73	725	325	328	325
query74	5958	5446	5506	5446
query75	3430	2635	2639	2635
query76	2736	911	886	886
query77	487	315	308	308
query78	10246	9970	9785	9785
query79	2592	510	521	510
query80	1060	462	470	462
query81	580	221	220	220
query82	1092	98	104	98
query83	246	172	173	172
query84	238	92	87	87
query85	1329	291	271	271
query86	449	304	315	304
query87	3270	3074	3100	3074
query88	3279	2463	2441	2441
query89	465	386	400	386
query90	1793	195	197	195
query91	132	103	101	101
query92	76	53	51	51
query93	1716	510	510	510
query94	1267	195	194	194
query95	433	334	396	334
query96	594	274	268	268
query97	3289	3056	3061	3056
query98	215	203	195	195
query99	1153	830	839	830
Total cold run time: 273114 ms
Total hot run time: 173419 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ba467343f6bdfa6edd7ebc563510473df4aaf6b5, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.51	0.51	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.54	0.48	0.49
query10	0.54	0.54	0.52
query11	0.15	0.12	0.11
query12	0.14	0.11	0.13
query13	0.60	0.59	0.61
query14	0.79	0.79	0.80
query15	0.83	0.83	0.81
query16	0.36	0.37	0.40
query17	0.98	0.96	1.04
query18	0.23	0.25	0.26
query19	1.82	1.83	1.81
query20	0.01	0.01	0.01
query21	15.42	0.67	0.66
query22	4.74	7.39	1.40
query23	18.26	1.35	1.29
query24	1.97	0.27	0.22
query25	0.16	0.08	0.08
query26	0.27	0.17	0.18
query27	0.08	0.08	0.08
query28	13.20	1.01	1.01
query29	12.54	3.34	3.31
query30	0.27	0.06	0.08
query31	2.86	0.39	0.38
query32	3.27	0.47	0.47
query33	2.88	2.89	2.90
query34	17.16	4.43	4.41
query35	4.47	4.48	4.52
query36	0.67	0.48	0.48
query37	0.19	0.16	0.15
query38	0.15	0.15	0.15
query39	0.05	0.03	0.04
query40	0.17	0.14	0.15
query41	0.09	0.05	0.06
query42	0.06	0.05	0.06
query43	0.05	0.04	0.04
Total cold run time: 109.71 s
Total hot run time: 30.28 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@jacktengg jacktengg merged commit c1ef016 into apache:master Jun 24, 2024
26 of 29 checks passed
@jacktengg jacktengg mentioned this pull request Jun 25, 2024
Merged
HappenLee pushed a commit that referenced this pull request Jun 25, 2024
@jacktengg
[fix](spill join) fix coredump of debug_string (#36723)
11201fe 
## Proposed changes

Pick #36715

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
@jacktengg @dataroaring
[fix](spill join) fix coredump of debug_string (#36715)
dd4cf74 
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacktengg @doris-robot @Gabriel39 @zhiqiang-hhhh @HappenLee @dataroaring