-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insert into mode is not restriction for BE storage_flood_stage_usage_percent param #36657
base: branch-2.1
Are you sure you want to change the base?
Conversation
…age_percent param # Steps to reproduce: ## 1,Create Doris ENV ``` 3 FE + 4 BE FE have one data path:/data1 BE have one data path:/data1 ``` ## 2,Create table ``` create table test( id bigint not null, name varchar(100) ) duplicate key(id1) distributed by hash(id1) buckets 1 properties ( "replication_num" = "3" ); ``` ## 3,modify all BE param & restart doris ``` BE.storage_flood_stage_usage_percent=1 -- set to 100T BE.storage_flood_stage_left_capacity_bytes=1099511627776 ``` ## 4,insert data ``` insert into test values (1,'test_name'); ``` ## 5,result ``` Query OK, 1 row affected (0.09 sec) {'label':'label_1bfb0be2ee8b424f_8f9a3a25ca638bc1', 'status':'VISIBLE', 'txnId':'4419'} ``` ## 6,after fix: ``` ERROR 1105 (HY000) at line 1: errCode = 2, detailMessage = (be0)[E-232]disk 10878111130781813261 exceed capacity limit. ``` [ci skip]
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity be ut coverage result: |
Fix insert into mode is not restriction for BE storage_flood_stage_usage_percent param
Fix insert into mode is not restriction for BE storage_flood_stage_usage_percent param
clang-tidy review says "All clean, LGTM! 👍" |
|
||
if (data_dir != nullptr && | ||
data_dir->reach_capacity_limit(stat.data_size + stat.index_size)) { | ||
LOG(INFO) << "segment size is " << (stat.data_size + stat.index_size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe debug log is better.
After disk usage is high, lots of these logs will take large disk space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already change to DEBUG
Steps to reproduce:
1,Create Doris ENV
2,Create table
3,modify all BE param & restart doris
4,insert data
5,result
6,after fix:
[ci skip]
Proposed changes
Issue Number: close #xxx