Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](clone) Increase robustness for clone #36642

Merged
merged 2 commits into from
Jun 21, 2024
Merged

[fix](clone) Increase robustness for clone #36642

merged 2 commits into from
Jun 21, 2024

Conversation

deardeng
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@deardeng
Copy link
Contributor Author

run buildall

yujun777
yujun777 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9009/24699)
Line Coverage: 28.01% (73889/263767)
Region Coverage: 27.49% (38380/139597)
Branch Coverage: 24.19% (19562/80864)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3acad8b6a859df6ba381bcb56656941be65703e7_3acad8b6a859df6ba381bcb56656941be65703e7/report/index.html

dataroaring
dataroaring previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9009/24699)
Line Coverage: 28.02% (73893/263761)
Region Coverage: 27.49% (38377/139599)
Branch Coverage: 24.19% (19562/80866)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0db0efeb0c250b840324d441074b41575c666f10_0db0efeb0c250b840324d441074b41575c666f10/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40614 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0db0efeb0c250b840324d441074b41575c666f10, data reload: false

------ Round 1 ----------------------------------
q1	17636	4331	4267	4267
q2	2030	191	206	191
q3	10453	1173	1123	1123
q4	10177	780	813	780
q5	7494	2655	2631	2631
q6	229	141	138	138
q7	960	645	598	598
q8	9226	2087	2064	2064
q9	9017	6479	6460	6460
q10	8924	3729	3722	3722
q11	449	257	239	239
q12	481	236	240	236
q13	17932	2997	3025	2997
q14	263	224	234	224
q15	514	490	485	485
q16	528	392	389	389
q17	964	678	649	649
q18	7997	7456	7478	7456
q19	8039	1443	1461	1443
q20	665	329	346	329
q21	4978	3840	3914	3840
q22	401	353	355	353
Total cold run time: 119357 ms
Total hot run time: 40614 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4379	4260	4244	4244
q2	376	275	269	269
q3	3140	2881	2949	2881
q4	1974	1728	1748	1728
q5	5469	5482	5518	5482
q6	228	141	135	135
q7	2214	1855	1865	1855
q8	3323	3382	3432	3382
q9	8679	8809	8704	8704
q10	4137	3788	3766	3766
q11	599	524	500	500
q12	845	649	621	621
q13	16108	3216	3166	3166
q14	324	282	271	271
q15	521	484	486	484
q16	512	440	418	418
q17	1828	1505	1509	1505
q18	7958	7871	7708	7708
q19	1819	1634	1724	1634
q20	2155	1891	1872	1872
q21	5124	5113	4744	4744
q22	631	531	592	531
Total cold run time: 72343 ms
Total hot run time: 55900 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174116 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0db0efeb0c250b840324d441074b41575c666f10, data reload: false

query1	926	387	373	373
query2	6442	2390	2482	2390
query3	6639	206	207	206
query4	19831	17233	17280	17233
query5	3623	470	456	456
query6	240	156	154	154
query7	4588	305	285	285
query8	328	294	310	294
query9	8544	2448	2418	2418
query10	580	328	279	279
query11	10522	10250	10148	10148
query12	121	83	81	81
query13	1624	367	370	367
query14	10055	6990	6833	6833
query15	222	190	188	188
query16	7451	281	256	256
query17	1442	533	548	533
query18	1922	274	275	274
query19	201	156	155	155
query20	91	82	83	82
query21	214	160	127	127
query22	4419	4148	4020	4020
query23	34053	33854	33771	33771
query24	11201	2835	2836	2835
query25	643	382	360	360
query26	1254	157	151	151
query27	3082	333	322	322
query28	7741	2150	2128	2128
query29	891	639	653	639
query30	288	150	157	150
query31	964	756	765	756
query32	96	53	55	53
query33	754	291	278	278
query34	1067	472	478	472
query35	731	654	616	616
query36	1135	987	974	974
query37	165	71	76	71
query38	2942	2815	2845	2815
query39	886	860	832	832
query40	206	134	142	134
query41	62	55	53	53
query42	116	104	112	104
query43	583	564	527	527
query44	1119	721	728	721
query45	199	168	168	168
query46	1074	752	711	711
query47	1870	1759	1754	1754
query48	372	299	310	299
query49	870	413	418	413
query50	767	396	393	393
query51	6940	6742	6748	6742
query52	106	93	92	92
query53	360	294	291	291
query54	924	487	459	459
query55	76	71	76	71
query56	296	282	282	282
query57	1113	1029	1065	1029
query58	256	260	278	260
query59	3396	3401	3221	3221
query60	307	280	278	278
query61	93	89	89	89
query62	596	438	438	438
query63	319	290	292	290
query64	8862	2240	1786	1786
query65	3190	3134	3130	3130
query66	857	323	343	323
query67	15383	15039	14754	14754
query68	6141	549	545	545
query69	653	486	379	379
query70	1194	1141	1106	1106
query71	481	263	294	263
query72	7260	5453	5495	5453
query73	803	326	328	326
query74	5915	5505	5564	5505
query75	4036	2670	2666	2666
query76	4231	904	933	904
query77	673	294	297	294
query78	10340	9837	9772	9772
query79	2435	511	504	504
query80	1376	471	470	470
query81	577	215	221	215
query82	489	101	103	101
query83	195	166	163	163
query84	275	87	84	84
query85	1117	288	326	288
query86	382	322	306	306
query87	3310	3138	3084	3084
query88	3536	2466	2431	2431
query89	472	395	373	373
query90	1882	189	186	186
query91	126	100	99	99
query92	59	49	51	49
query93	3903	510	495	495
query94	1100	185	187	185
query95	412	319	315	315
query96	585	274	274	274
query97	3278	3074	3057	3057
query98	209	203	203	203
query99	1180	834	869	834
Total cold run time: 276855 ms
Total hot run time: 174116 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0db0efeb0c250b840324d441074b41575c666f10, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.09	0.09
query5	0.50	0.49	0.50
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.51	0.50
query10	0.54	0.55	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.77	0.78	0.80
query15	0.85	0.82	0.82
query16	0.37	0.37	0.38
query17	0.96	1.05	1.03
query18	0.22	0.24	0.24
query19	1.81	1.73	1.72
query20	0.01	0.02	0.01
query21	15.41	0.64	0.64
query22	4.03	7.49	1.84
query23	18.31	1.34	1.25
query24	2.14	0.22	0.23
query25	0.17	0.09	0.08
query26	0.25	0.17	0.18
query27	0.08	0.08	0.08
query28	13.30	1.03	1.03
query29	12.62	3.38	3.29
query30	0.26	0.07	0.06
query31	2.87	0.41	0.39
query32	3.24	0.49	0.48
query33	2.87	2.89	2.89
query34	17.35	4.64	4.62
query35	4.77	4.74	4.76
query36	0.69	0.48	0.49
query37	0.19	0.17	0.16
query38	0.17	0.15	0.15
query39	0.05	0.03	0.04
query40	0.19	0.16	0.16
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.84 s
Total hot run time: 31.2 s

@dataroaring dataroaring merged commit 73f0101 into apache:master Jun 21, 2024
25 of 28 checks passed
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@deardeng @dataroaring
[fix](clone) Increase robustness for clone (#36642)
63800df
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 8, 2024
@deardeng
[fix](clone) Increase robustness for clone (apache#36642)
7c2789a
@deardeng deardeng mentioned this pull request Jul 8, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 9, 2024
@deardeng
[fix](clone) Increase robustness for clone #36642 (#37413)
5247e0f 
cherry pick from #36642
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 9, 2024
@deardeng
[fix](clone) Increase robustness for clone (apache#36642)
c6e68d9
dataroaring pushed a commit that referenced this pull request Jul 9, 2024
@deardeng
[fix](clone) Increase robustness for clone (#36642) (#37550)
55d3dd3 
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@dataroaring dataroaring mentioned this pull request Jul 9, 2024
Merged
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@deardeng
[fix](clone) Increase robustness for clone (apache#36642) (apache#37550)
ad1dfee 
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujun777 yujun777 yujun777 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.13-merged dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deardeng @doris-robot @dataroaring @yujun777