make build script portable on Mac OS #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sduzh Please add a issue.
|
imay
added
kind/chore
imay
reviewed
May 7, 2020
thirdparty/build-thirdparty.sh
Outdated
| @@ -295,7 +295,7 @@ build_gtest() { | |||
| check_if_source_exist $GTEST_SOURCE | |||
|
|
|||
| cd $TP_SOURCE_DIR/$GTEST_SOURCE | |||
| mkdir build -p && cd build | |||
| mkdir -p bld && cd bld | |||
There was a problem hiding this comment.
I think build is easier to understand than bld
There was a problem hiding this comment.
Projects that support build by bazel will contain a file named BUILD. Since the filesystem of Mac OS is not case sensitive, you cannot create a directory named build for those projects.
double-conversion-3.1.1/BUILD
re2-2017-05-01/BUILD
protobuf-3.5.1/BUILD
gflags-2.2.0/BUILD
incubator-brpc-0.9.5/BUILD
brotli-1.0.7/BUILD
flatbuffers-1.10.0/BUILD
mysql-server-mysql-5.7.18/BUILD
cctz-2.3/BUILD
glog-0.4.0/BUILD
There was a problem hiding this comment.
Thanks，I see.
Better to add comments about this reason. And is doris_build better?
1. options of command `mkdir` and `cp` must be put before arguments on Mac OS. 2. directory name `build` is conflict with file `BUILD` on Mac OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkdirandcpmust be put before arguments on Mac OS.buildis conflict with fileBUILDon Mac OS.