Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exec](pipeline) runtime filter wait time #34872

Merged
merged 3 commits into from
May 20, 2024
Merged

[exec](pipeline) runtime filter wait time #34872

merged 3 commits into from
May 20, 2024

Conversation

HappenLee
Copy link
Contributor

@HappenLee HappenLee commented May 15, 2024 •
edited
Loading

Proposed changes

  1. Remote RF should wait all local rf ready and start to wait runtimne filter

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.65% (8983/25195)
Line Coverage: 27.32% (74268/271831)
Region Coverage: 26.55% (38375/144530)
Branch Coverage: 23.37% (19570/83752)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f576868d2b9e97f9328a6586360b9aefada45740_f576868d2b9e97f9328a6586360b9aefada45740/report/index.html

Gabriel39
Gabriel39 previously approved these changes May 20, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9008/25231)
Line Coverage: 27.36% (74507/272305)
Region Coverage: 26.61% (38540/144831)
Branch Coverage: 23.44% (19669/83912)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9be4a70c3934bc3380a8c51b698986effaea20f2_9be4a70c3934bc3380a8c51b698986effaea20f2/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.68% (9010/25253)
Line Coverage: 27.33% (74502/272560)
Region Coverage: 26.58% (38520/144937)
Branch Coverage: 23.41% (19656/83948)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42186c59a4737e6047f03be684efcdd7e43d8196_42186c59a4737e6047f03be684efcdd7e43d8196/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2024
@HappenLee HappenLee merged commit 0e95a6a into apache:master May 20, 2024
24 of 28 checks passed
@HappenLee HappenLee mentioned this pull request May 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request May 26, 2024
@HappenLee @dataroaring
[exec](pipeline) runtime filter wait time (#34872)
6127cd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HappenLee @doris-robot @Gabriel39 @zhangstar333 @yiguolei @dataroaring