Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](cloud) Sync cloud modification #34213

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[chore](cloud) Sync cloud modification #34213

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2ae2d0
(selectdb-cloud) Print key if not found
gavinchou Jan 31, 2024
b234db7
(selectdb-cloud) Change flush_thread_num_per_store=24 vertical_compac…
gavinchou Apr 27, 2024
4adb559
(selectdb-cloud) Optimize regression test of analyze_stats
gavinchou Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(selectdb-cloud) Print key if not found
  • Loading branch information
@gavinchou
gavinchou committed Apr 27, 2024
commit e2ae2d0f3bc2c97b6c0d86da0b77c06c6a78bd19
7 changes: 4 additions & 3 deletions cloud/src/meta-service/meta_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,20 @@ void get_tablet_idx(MetaServiceCode& code, std::string& msg, Transaction* txn,
} else {
code = cast_as<ErrCategory::READ>(err);
}
msg = fmt::format("failed to get tablet_idx, err={} tablet_id={} ", err, tablet_id);
msg = fmt::format("failed to get tablet_idx, err={} tablet_id={} key={}", err, tablet_id,
hex(key));
return;
}
if (!tablet_idx.ParseFromString(val)) [[unlikely]] {
code = MetaServiceCode::PROTOBUF_PARSE_ERR;
msg = fmt::format("malformed tablet index value, key={}", hex(key));
msg = fmt::format("malformed tablet index value, tablet_id={} key={}", tablet_id, hex(key));
return;
}
if (tablet_id != tablet_idx.tablet_id()) [[unlikely]] {
code = MetaServiceCode::UNDEFINED_ERR;
msg = "internal error";
LOG(WARNING) << "unexpected error given_tablet_id=" << tablet_id
<< " idx_pb_tablet_id=" << tablet_idx.tablet_id();
<< " idx_pb_tablet_id=" << tablet_idx.tablet_id() << " key=" << hex(key);
return;
}
}
Expand Down