Make running profile clearer and more intuitive to improve usability (#3365) #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3365) This CL mainly made the following modifications: 1. Delete Invalid method in Running Profile Class. 2. Move Memlimit Counter from blockmgr to frgment and add PeakMemUsage Counter 3. Fix the bug of buffer pool memlimit counter 4. Call compute_time_in_profile() before pretty_print() to show the _local_time_percent without child running profile 5. Add TransferThread ThreadToken count in AveThreadToken Counter
imay
reviewed
Apr 23, 2020
| @@ -1038,6 +1038,7 @@ Status OlapScanNode::normalize_binary_predicate(SlotDescriptor* slot, ColumnValu | |||
|
|
|||
| void OlapScanNode::transfer_thread(RuntimeState* state) { | |||
| // scanner open pushdown to scanThread | |||
| state->resource_pool()->acquire_thread_token(); | |||
There was a problem hiding this comment.
Can you tell the side effect of this operation? Will this thread hang if there is not enough thread resource?
There was a problem hiding this comment.
Add this operation just to Make AverageThreadTokens more accurate
- AverageThreadTokens: 1.00
Do not warry thread hang on this operation。
acquire_thread_token() just do a lightweight add operation without doing the really thread assignment
inline void ThreadResourceMgr::ResourcePool::acquire_thread_token() {
__sync_fetch_and_add(&_num_threads, 1);
}
be/src/runtime/runtime_state.cpp
Outdated
| _query_mem_tracker.reset( | ||
| new MemTracker(bytes_limit, runtime_profile()->name(), _exec_env->process_mem_tracker())); | ||
| new MemTracker(&_profile, bytes_limit, runtime_profile()->name(), _exec_env->process_mem_tracker())); |
There was a problem hiding this comment.
If you add profile for this memory tracker, why not _instance_mem_tracker?
There was a problem hiding this comment.
yes，I check code。the _instance_mem_tracker is more appropriate
change profile counter to _instance_mem_tracker
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Apr 28, 2020
…usability (apache#3365) (apache#3383) This CL mainly made the following modifications: 1. Delete Invalid method in Running Profile Class. 2. Move Memlimit Counter from blockmgr to fragment and add PeakMemUsage Counter 3. Fix the bug of buffer pool memlimit counter 4. Call compute_time_in_profile() before pretty_print() to show the _local_time_percent without child running profile 5. Add TransferThread ThreadToken count in AveThreadToken Counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL mainly made the following modifications:
ISSUE: #3365