Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](Nereids): date literal support Zone #33534

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[feature](Nereids): date literal support Zone #33534

merged 1 commit into from
Apr 15, 2024

Conversation

jackwener
Copy link
Member

Proposed changes

support

'2022-05-01 01:02:55 +02:30
'2022-05-01 01:02:55 Asia/Shanghai

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jackwener
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38406 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a55a69f71fb7da85d099cefc12e1087b8ebb793c, data reload: false

------ Round 1 ----------------------------------
q1	17627	4246	4204	4204
q2	2000	195	192	192
q3	10438	1175	1171	1171
q4	10192	739	821	739
q5	7497	2697	2640	2640
q6	222	133	134	133
q7	993	619	604	604
q8	9215	2070	2024	2024
q9	7871	6549	6560	6549
q10	8584	3536	3548	3536
q11	453	249	239	239
q12	456	228	221	221
q13	18937	2937	2962	2937
q14	271	232	244	232
q15	514	468	476	468
q16	516	380	377	377
q17	960	634	658	634
q18	7321	6854	6741	6741
q19	3936	1513	1490	1490
q20	693	312	299	299
q21	3454	2678	2782	2678
q22	358	298	301	298
Total cold run time: 112508 ms
Total hot run time: 38406 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4327	4185	4153	4153
q2	366	259	263	259
q3	2916	2797	2683	2683
q4	1870	1568	1609	1568
q5	5266	5286	5285	5285
q6	214	127	126	126
q7	2274	1887	1892	1887
q8	3171	3318	3281	3281
q9	8678	8629	8667	8629
q10	4007	3903	3959	3903
q11	629	494	496	494
q12	793	648	632	632
q13	16375	3178	3206	3178
q14	339	294	294	294
q15	506	476	471	471
q16	491	465	452	452
q17	1795	1520	1521	1520
q18	8174	7823	7746	7746
q19	1685	1555	1525	1525
q20	2025	1861	1845	1845
q21	5089	5009	4976	4976
q22	545	477	467	467
Total cold run time: 71535 ms
Total hot run time: 55374 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184369 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a55a69f71fb7da85d099cefc12e1087b8ebb793c, data reload: false

query1	1264	1118	1119	1118
query2	7583	2529	2452	2452
query3	6653	201	198	198
query4	37281	21462	21319	21319
query5	4118	388	387	387
query6	232	187	172	172
query7	4019	289	284	284
query8	216	166	179	166
query9	5827	2281	2277	2277
query10	362	231	254	231
query11	14704	14190	14265	14190
query12	139	105	87	87
query13	990	368	363	363
query14	9023	6962	6897	6897
query15	214	177	177	177
query16	7165	260	255	255
query17	1697	568	566	566
query18	1528	272	264	264
query19	191	142	151	142
query20	93	85	88	85
query21	196	122	123	122
query22	5065	4830	4755	4755
query23	33646	33309	33540	33309
query24	11581	3009	3115	3009
query25	627	400	384	384
query26	1509	165	167	165
query27	3174	360	356	356
query28	7622	2115	2119	2115
query29	891	629	619	619
query30	269	175	167	167
query31	925	744	717	717
query32	64	52	52	52
query33	554	254	252	252
query34	978	487	508	487
query35	871	708	713	708
query36	1048	939	949	939
query37	142	68	68	68
query38	3705	3642	3656	3642
query39	1634	1594	1566	1566
query40	178	128	127	127
query41	46	44	46	44
query42	105	96	96	96
query43	616	574	554	554
query44	1402	727	738	727
query45	287	281	263	263
query46	1118	773	749	749
query47	2074	1983	2011	1983
query48	379	305	291	291
query49	920	368	372	368
query50	795	394	393	393
query51	6843	6866	6582	6582
query52	114	88	95	88
query53	342	279	281	279
query54	254	231	219	219
query55	74	74	73	73
query56	230	216	217	216
query57	1215	1155	1097	1097
query58	212	196	197	196
query59	3477	3287	3251	3251
query60	244	252	231	231
query61	92	91	104	91
query62	601	434	453	434
query63	304	282	282	282
query64	4219	3864	3877	3864
query65	3081	3015	3058	3015
query66	727	318	311	311
query67	15535	15131	14847	14847
query68	6989	536	531	531
query69	588	300	299	299
query70	1261	1133	1094	1094
query71	437	263	267	263
query72	6632	2668	2428	2428
query73	820	318	317	317
query74	7098	6538	6512	6512
query75	3138	2361	2337	2337
query76	4114	1126	1131	1126
query77	627	249	255	249
query78	10873	10229	10240	10229
query79	4567	538	536	536
query80	2086	431	416	416
query81	516	225	237	225
query82	1589	148	97	97
query83	325	172	173	172
query84	255	84	83	83
query85	1118	272	272	272
query86	457	286	264	264
query87	3716	3485	3536	3485
query88	5994	2269	2274	2269
query89	495	374	373	373
query90	1867	179	179	179
query91	125	100	97	97
query92	58	48	50	48
query93	5615	510	510	510
query94	1073	181	181	181
query95	392	298	298	298
query96	605	257	264	257
query97	2657	2448	2448	2448
query98	225	227	222	222
query99	1171	837	819	819
Total cold run time: 300767 ms
Total hot run time: 184369 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a55a69f71fb7da85d099cefc12e1087b8ebb793c, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.05	0.06
query4	1.66	0.07	0.07
query5	0.49	0.50	0.48
query6	1.13	0.66	0.65
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.50	0.50
query10	0.55	0.56	0.55
query11	0.17	0.12	0.12
query12	0.14	0.12	0.11
query13	0.59	0.58	0.58
query14	0.77	0.78	0.78
query15	0.81	0.82	0.80
query16	0.36	0.35	0.38
query17	0.96	1.05	0.94
query18	0.22	0.23	0.26
query19	1.90	1.79	1.74
query20	0.01	0.02	0.01
query21	15.42	0.67	0.64
query22	3.77	6.35	2.28
query23	18.31	1.34	1.28
query24	2.09	0.21	0.21
query25	0.15	0.08	0.07
query26	0.26	0.16	0.15
query27	0.09	0.07	0.08
query28	13.34	0.99	0.99
query29	12.60	3.26	3.20
query30	0.26	0.06	0.05
query31	2.89	0.38	0.37
query32	3.28	0.46	0.46
query33	2.81	2.75	2.85
query34	17.07	4.44	4.47
query35	4.47	4.50	4.47
query36	0.66	0.47	0.46
query37	0.18	0.16	0.16
query38	0.16	0.14	0.14
query39	0.05	0.03	0.03
query40	0.16	0.14	0.13
query41	0.10	0.05	0.04
query42	0.05	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 108.93 s
Total hot run time: 30.53 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit a55a69f71fb7da85d099cefc12e1087b8ebb793c with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@jackwener
Copy link
Member Author

support

'2022-05-01 01:02:55+02:30
'2022-05-01 01:02:55Asia/Shanghai

@jackwener jackwener merged commit 96eb7ec into apache:master Apr 15, 2024
27 of 29 checks passed
@jackwener jackwener deleted the time branch April 15, 2024 02:18
jackwener added a commit to jackwener/doris that referenced this pull request Apr 15, 2024
@jackwener
[feature](Nereids): date literal suppose Zone (apache#33534)
1a357db 
support
```
'2022-05-01 01:02:55+02:30
'2022-05-01 01:02:55Asia/Shanghai
```

(cherry picked from commit 96eb7ec)
jackwener added a commit to jackwener/doris that referenced this pull request Apr 15, 2024
@jackwener
[feature](Nereids): date literal suppose Zone (apache#33534)
5453808
@jackwener jackwener mentioned this pull request Apr 15, 2024
Merged
jackwener added a commit that referenced this pull request Apr 16, 2024
@jackwener
[feature](Nereids): date literal suppose Zone (#33534) (#33683)
ee47404
yiguolei pushed a commit that referenced this pull request Apr 16, 2024
@jackwener @Doris-Extras
[feature](Nereids): date literal suppose Zone (#33534)
8cfbc0e 
support
```
'2022-05-01 01:02:55+02:30
'2022-05-01 01:02:55Asia/Shanghai
```
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@jackwener @Doris-Extras
[feature](Nereids): date literal suppose Zone (#33534)
b2face0 
support
```
'2022-05-01 01:02:55+02:30
'2022-05-01 01:02:55Asia/Shanghai
```
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@jackwener
[feature](Nereids): date literal suppose Zone (apache#33534) (apache#…
8e9810b 
…33683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanji-x keanji-x keanji-x approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.9-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jackwener @doris-robot @keanji-x @starocean999 @xiaokang @wm1581066