Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](log) print query id before logging profile in be.INFO #32922

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

similar #32915

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38098 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f35f8686ee79758ace841ea83ca5ee54c71ef83b, data reload: false

------ Round 1 ----------------------------------
q1	17705	4413	4218	4218
q2	2744	165	158	158
q3	11365	1138	1227	1138
q4	10716	823	760	760
q5	7683	3081	3070	3070
q6	202	124	126	124
q7	1055	592	578	578
q8	9330	2020	1989	1989
q9	7189	6590	6570	6570
q10	8405	3415	3574	3415
q11	434	236	218	218
q12	375	213	196	196
q13	17792	2828	2865	2828
q14	238	205	206	205
q15	513	475	451	451
q16	472	374	370	370
q17	942	536	629	536
q18	7127	6494	6481	6481
q19	1547	1407	1484	1407
q20	550	271	264	264
q21	3561	2913	2836	2836
q22	354	286	309	286
Total cold run time: 110299 ms
Total hot run time: 38098 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4068	4044	4090	4044
q2	334	231	232	231
q3	2963	2828	2833	2828
q4	1845	1594	1597	1594
q5	5326	5328	5330	5328
q6	199	116	118	116
q7	2213	1854	1862	1854
q8	3165	3254	3262	3254
q9	8714	8700	8620	8620
q10	3782	3780	3767	3767
q11	550	444	437	437
q12	720	556	554	554
q13	16890	2864	2826	2826
q14	280	248	243	243
q15	479	466	468	466
q16	465	416	424	416
q17	1729	1485	1468	1468
q18	7264	7157	7049	7049
q19	1586	1484	1547	1484
q20	1891	1722	1700	1700
q21	4711	4628	4644	4628
q22	540	461	434	434
Total cold run time: 69714 ms
Total hot run time: 53341 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.24% (8739/24796)
Line Coverage: 27.02% (71525/264675)
Region Coverage: 26.27% (37116/141299)
Branch Coverage: 23.16% (18974/81916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f35f8686ee79758ace841ea83ca5ee54c71ef83b_f35f8686ee79758ace841ea83ca5ee54c71ef83b/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 182386 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f35f8686ee79758ace841ea83ca5ee54c71ef83b, data reload: false

query1	945	374	352	352
query2	6549	1952	1795	1795
query3	6698	209	207	207
query4	31879	21273	21365	21273
query5	4279	406	393	393
query6	270	174	190	174
query7	4651	288	287	287
query8	228	169	184	169
query9	9428	2327	2317	2317
query10	560	247	258	247
query11	15133	14212	14325	14212
query12	136	90	90	90
query13	1631	417	422	417
query14	9140	7906	7927	7906
query15	249	193	193	193
query16	8203	262	261	261
query17	1982	589	559	559
query18	2115	303	292	292
query19	349	160	155	155
query20	92	90	88	88
query21	211	127	131	127
query22	5004	4846	4782	4782
query23	33843	32846	32797	32797
query24	11724	2914	2877	2877
query25	667	381	392	381
query26	1809	160	158	158
query27	3157	346	356	346
query28	7663	1891	1893	1891
query29	1067	642	631	631
query30	309	148	152	148
query31	1011	756	715	715
query32	98	57	58	57
query33	777	269	249	249
query34	1116	496	509	496
query35	833	624	615	615
query36	1043	866	907	866
query37	284	70	68	68
query38	3522	3462	3474	3462
query39	1495	1465	1442	1442
query40	289	124	116	116
query41	52	47	50	47
query42	105	102	98	98
query43	483	453	456	453
query44	1180	750	731	731
query45	284	257	276	257
query46	1114	694	674	674
query47	1918	1833	1832	1832
query48	460	369	368	368
query49	1253	331	343	331
query50	757	369	368	368
query51	6733	6698	6656	6656
query52	105	93	87	87
query53	348	276	286	276
query54	331	284	238	238
query55	89	82	77	77
query56	247	229	230	229
query57	1225	1135	1139	1135
query58	248	208	209	208
query59	2815	2709	2741	2709
query60	266	243	250	243
query61	117	116	114	114
query62	664	458	454	454
query63	308	284	282	282
query64	6930	4041	3964	3964
query65	3110	3073	3047	3047
query66	1410	359	355	355
query67	15566	15092	15012	15012
query68	6366	523	531	523
query69	597	378	382	378
query70	1287	1128	1126	1126
query71	468	272	266	266
query72	6565	2738	2586	2586
query73	726	319	314	314
query74	6885	6465	6370	6370
query75	3296	2216	2208	2208
query76	4362	898	913	898
query77	610	264	255	255
query78	11028	10298	10142	10142
query79	8651	519	536	519
query80	1661	380	374	374
query81	530	219	216	216
query82	1492	85	82	82
query83	215	143	145	143
query84	290	84	81	81
query85	1525	317	313	313
query86	474	301	312	301
query87	3734	3583	3541	3541
query88	5161	2346	2338	2338
query89	524	371	365	365
query90	2018	176	176	176
query91	168	138	139	138
query92	67	47	48	47
query93	7112	502	489	489
query94	1142	177	177	177
query95	418	324	330	324
query96	616	272	277	272
query97	2666	2487	2477	2477
query98	232	213	208	208
query99	1232	883	886	883
Total cold run time: 310675 ms
Total hot run time: 182386 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit f35f8686ee79758ace841ea83ca5ee54c71ef83b with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.2 seconds inserted 10000000 Rows, about 704K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 8bde14f into apache:master Mar 27, 2024
26 of 31 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the chore-opt-log branch March 28, 2024 09:14
Jibing-Li added a commit that referenced this pull request Mar 29, 2024
* [fix](merge cloud) Fix cloud be set be tag map (#32864)

* [chore] Add gavinchou to collaborators (#32881)

* [chore](show) support statement to show views from table (#32358)

MySQL [test]> show views;
+----------------+
| Tables_in_test |
+----------------+
| t1_view        |
| t2_view        |
+----------------+
2 rows in set (0.00 sec)

MySQL [test]> show views like '%t1%';
+----------------+
| Tables_in_test |
+----------------+
| t1_view        |
+----------------+
1 row in set (0.01 sec)

MySQL [test]> show views where create_time > '2024-03-18';
+----------------+
| Tables_in_test |
+----------------+
| t2_view        |
+----------------+
1 row in set (0.02 sec)

* [Enhancement](ranger) Disable some permission operations when Ranger or LDAP are enabled (#32538)

Disable some permission operations when Ranger or LDAP are enabled.

* [chore](ci) exclude unstable trino_connector case (#32892)

Co-authored-by: stephen <hello-stephen@qq.com>

* [fix](Nereids) NPE when create table with implicit index type (#32893)

* [improvement](mtmv) Support more join types for query rewriting by materialized view (#32685)

This pattern of rewriting is supported for multi-table joins and supported join types is as following:

INNER JOIN
LEFT OUTER JOIN
RIGHT OUTER JOIN
FULL OUTER JOIN
LEFT SEMI JOIN
RIGHT SEMI JOIN
LEFT ANTI JOIN
RIGHT ANTI JOIN

* [Serde](Variant) support arrow serialization for varint type (#32780)

* [fix](multicatalog) fix no data error when read hive table on cosn (#32815)

Currently, when reading a hive on cosn table, doris return empty result, but the table has data.
iceberg on cosn is ok.
The reason is misuse of cosn's file sytem. according to cosn's doc, its fs.cosn.impl should be org.apache.hadoop.fs.CosFileSystem

* [fix](nereids)EliminateGroupByConstant should replace agg's output after removing constant group by keys (#32878)

* [Fix](executor)Fix regression test for test_active_queries/test_backend_active_tasks #32899

* [fix](iceberg) fix iceberg catalog bug and p2 test cases (#32898)

1. Fix iceberg catalog bug

    This PR #30198 change the logic of `IcebergHMSExternalCatalog.java`,
    to get locationUrl by calling hive metastore's `getCatalog()` method.
    But this method only exists in hive 3+. So it will fail if we using hive 2.x.

    I temporary remove this logic, because this logic is only used from iceberg table writing.
    Which is still under development. We will rethink this logic later.

2. Fix test cases

    Some of P2 test cases missed `order_qt`. And because the output format of the floating point
    type is changed, some result in `out` files need to be regenerated.

* [revert](jni) revert part of #32455 (#32904)

* [fix](spill) Avoid releasing resources while spill tasks are executing (#32783)

* [chore](log) print query id before logging profile in be.INFO (#32922)

* [fix](grace-exit) Stop incorrectly of reportwork cause heap use after free #32929

* [improvement](decommission be) decommission check replica num (#32748)

* [fix](arrow-flight) Fix reach limit of connections error (#32911)

Fix Reach limit of connections error
in fe.conf , arrow_flight_token_cache_size is mandatory less than qe_max_connection/2. arrow flight sql is a stateless protocol, connection is usually not actively disconnected, bearer token is evict from the cache will unregister ConnectContext.

Fix ConnectContext.command not be reset to COM_SLEEP in time, this will result in frequent kill connection after query timeout.

Fix bearer token evict log and exception.

TODO: use arrow flight session: https://mail.google.com/mail/u/0/#inbox/FMfcgzGxRdxBLQLTcvvtRpqsvmhrHpdH

* [bugfix](cloud) few variable not initialized (#32868)

../../cloud/src/recycler/meta_checker.cpp
can cause uninitialised memory read.

* [fix](arrow-flight) Fix arrow flight sql compatible with JDK 17 and upgrade arrow 15.0.2 (#32796)

--add-opens=java.base/java.nio=ALL-UNNAMED, see: https://arrow.apache.org/docs/java/install.html#java-compatibility
groovy use flight sql connection to execute query SUM(MAX(c1) OVER (PARTITION BY)) report error: AGGREGATE clause must not contain analytic expressions, but no problem in Java execute it with jdbc::arrow-flight-sql.
groovy not support print arrow array type, throw IndexOutOfBoundsException.
"arrow_flight_sql" not support two phase read
./run-regression-test.sh --run --clean -g arrow_flight_sql

* [fix](spill) SpillStream's writer maybe may not have been finalized (#32931)

* [improvement](spill) Disable DistinctStreamingAgg when spill is enabled (#32932)

* [Improve](inverted_index) update clucene and improve array inverted index writer  (#32436)

* [Performance](exec) replace SipHash in function by XXHash (#32919)

* [feature](agg) add aggregate function sum0 (#32541)

* [improvement](mtmv) Support to get tables in materialized view when collecting table in plan (#32797)

Support to get tables in materialized view when collecting table in plan

table scehma as fllowing:

create materialized view mv1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 1 
PROPERTIES ('replication_num' = '1')
 as 
select 
  t1.c1, 
  t3.c2 
from 
  table1 t1 
  inner join table3 t3 on t1.c1 = t3.c2

if get table from the plan as follwoing, we can get [table1, table3, table2], the mv1 is expanded to get base tables;

SELECT 
  mv1.*, 
  uuid() 
FROM 
  mv1 LEFT SEMI 
  JOIN table2 ON mv1.c1 = table2.c1 
WHERE 
  mv1.c1 IN (
    SELECT 
      c1 
    FROM 
      table2
  ) 
  OR mv1.c1 < 10

* [enhance](mtmv)support olap table partition column is null (#32698)

* [enhancement](cloud) add table version to cloud (#32738)

Add table version to cloud.

In Fe:
Get: If Fe is cloud mode, get table version from meta service.
Update: Op drop/replace temp partition, commit transaction.

In meta service:
Add: create Index. init value is 1.
Remove: by recycler.
Update: commit/drop partition rpc, commit txn rpc. Atomic++.

* [fix](cloud) schema change from not null to null (#32913)

1. Use equals instead of == for type comparing
2. null bitmap size is reisze by size of ref column.

* [feature](Nereids): add ColumnPruningPostProcessor. (#32800)

* [case](rowpolicy)fix row policy has been exist (#32880)

* [fix](pipeline) fix use error row desc when origin block clear (#32803)

* [fix](Nereids) support variant column with index when create table (#32948)

* [opt](Nereids) support create table with variant type (#32953)

* [test](insert-overwrite) Add insert overwrite auto detect concurrency cases (#32935)

* [fix](compile) fe cannot compile in idea (#32955)

* [enhancement](plsql) Support select * from routines (#32866)

Support show of plsql procedure using select * from routines.

* [fix](trino-connector) fix `NoClassDefFoundError` of hudi `Utils` class (#32846)

Due to the change of this PR #32455 , the `trino-connector-scanner` package cannot access the `hudi_scanner` package, so the exception NoclassDeffounderror will appear.

We need to write a separate Utils class.

* [exec](column) change some complex column move to noexcept (#32954)

* [Enhancement](data skew) extends show data skew (#32732)

* [chore](test) let suite compatible with Nereids (#32964)

* Support identical column name in different index. (#32792)

* Limit the max string length to 1024 while collecting column stats to control BE memory usage. (#32470)

* [fix](merge-iterator) fix NOT_IMPLEMENTED_ERROR when read next block view (#32961)

* [improvement](executor)Add tag property for workload group #32874

* [fix](auth)unified workload and resource permission logic (#32907)

- `Grant resource` can no longer grant global `usage_priv`
-  `grant resource %` instead of `grant resource *`

before change:
```
grant usage_priv on resource * to f;
show grants for f\G
*************************** 1. row ***************************
      UserIdentity: 'f'@'%'
           Comment: 
          Password: No
             Roles: 
       GlobalPrivs: Usage_priv 
      CatalogPrivs: NULL
     DatabasePrivs: internal.information_schema: Select_priv ; internal.mysql: Select_priv 
        TablePrivs: NULL
          ColPrivs: NULL
     ResourcePrivs: NULL
 CloudClusterPrivs: NULL
WorkloadGroupPrivs: normal: Usage_priv 
```
after change
```
grant usage_priv on resource '%' to f;
show grants for f\G
*************************** 1. row ***************************
      UserIdentity: 'f'@'%'
           Comment: 
          Password: No
             Roles: 
       GlobalPrivs: NULL
      CatalogPrivs: NULL
     DatabasePrivs: internal.information_schema: Select_priv ; internal.mysql: Select_priv 
        TablePrivs: NULL
          ColPrivs: NULL
     ResourcePrivs: %: Usage_priv 
 CloudClusterPrivs: NULL
WorkloadGroupPrivs: normal: Usage_priv 

```

---------

Co-authored-by: yujun <yu.jun.reach@gmail.com>
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>
Co-authored-by: yongjinhou <109586248+yongjinhou@users.noreply.github.com>
Co-authored-by: Dongyang Li <hello_stephen@qq.com>
Co-authored-by: stephen <hello-stephen@qq.com>
Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Co-authored-by: seawinde <149132972+seawinde@users.noreply.github.com>
Co-authored-by: lihangyu <15605149486@163.com>
Co-authored-by: Yulei-Yang <yulei.yang0699@gmail.com>
Co-authored-by: starocean999 <40539150+starocean999@users.noreply.github.com>
Co-authored-by: wangbo <wangbo@apache.org>
Co-authored-by: Mingyu Chen <morningman@163.com>
Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Co-authored-by: zhiqiang <seuhezhiqiang@163.com>
Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Co-authored-by: Vallish Pai <vallishpai@gmail.com>
Co-authored-by: amory <wangqiannan@selectdb.com>
Co-authored-by: HappenLee <happenlee@hotmail.com>
Co-authored-by: Jensen <czjourney@163.com>
Co-authored-by: zhangdong <493738387@qq.com>
Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
Co-authored-by: jakevin <jakevingoo@gmail.com>
Co-authored-by: Mryange <59914473+Mryange@users.noreply.github.com>
Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com>
Co-authored-by: Xin Liao <liaoxinbit@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants