Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](index tool)Fix index_tool build error #32289

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Mar 15, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@qidaye
Copy link
Contributor Author

qidaye commented Mar 15, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38644 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1beca68070d917ba8e458430ed67654a042e0676, data reload: false

------ Round 1 ----------------------------------
q1	17641	4349	4139	4139
q2	2033	156	149	149
q3	10669	1076	912	912
q4	7795	741	781	741
q5	7446	2792	2745	2745
q6	190	123	122	122
q7	1170	827	820	820
q8	9444	2060	2002	2002
q9	7619	6450	6500	6450
q10	8542	3557	3650	3557
q11	427	212	221	212
q12	1122	304	297	297
q13	18130	2856	2839	2839
q14	272	256	252	252
q15	511	467	453	453
q16	510	398	397	397
q17	967	600	513	513
q18	7198	6643	6521	6521
q19	1555	1506	1389	1389
q20	546	291	275	275
q21	5902	3541	3606	3541
q22	353	318	336	318
Total cold run time: 110042 ms
Total hot run time: 38644 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4099	4098	4073	4073
q2	323	234	230	230
q3	2991	2852	2848	2848
q4	1860	1615	1537	1537
q5	5242	5292	5283	5283
q6	193	123	119	119
q7	2270	1849	1841	1841
q8	3177	3327	3293	3293
q9	8578	8556	8545	8545
q10	3715	3672	3726	3672
q11	536	437	434	434
q12	728	589	590	589
q13	10159	2916	2854	2854
q14	279	250	261	250
q15	486	460	465	460
q16	452	421	438	421
q17	1728	1472	1483	1472
q18	7428	7242	7233	7233
q19	1614	1581	1530	1530
q20	1917	1680	1727	1680
q21	4912	4580	4696	4580
q22	596	451	446	446
Total cold run time: 63283 ms
Total hot run time: 53390 ms

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.94% (8573/24534)
Line Coverage: 26.65% (69482/260728)
Region Coverage: 25.94% (36089/139107)
Branch Coverage: 22.90% (18429/80478)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1beca68070d917ba8e458430ed67654a042e0676_1beca68070d917ba8e458430ed67654a042e0676/report/index.html

@yiguolei yiguolei merged commit 1db78fe into apache:master Mar 15, 2024
27 of 30 checks passed
@qidaye qidaye deleted the fix_index_tool_build branch March 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-conflict approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants