Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](plsql) Fix procedure key compatibility #31445

Merged
merged 6 commits into from
Feb 27, 2024
Merged

[opt](plsql) Fix procedure key compatibility #31445

merged 6 commits into from
Feb 27, 2024

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Feb 27, 2024 •
edited
Loading

Proposed changes

  1. use dbId replace dbName, because dbName may be renamed by Alter.
  2. procedure key add package name (only reserved, currently no plans to support package)
  3. Optimize procedure create and exception

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37895 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7764f0f5c24d8be00a7161cf4ca6b6ddd5d49bd, data reload: false

------ Round 1 ----------------------------------
q1	17767	4311	4031	4031
q2	2045	140	130	130
q3	10589	951	943	943
q4	4658	952	962	952
q5	7613	2886	2993	2886
q6	180	121	122	121
q7	1219	764	752	752
q8	9249	1978	2028	1978
q9	7168	6328	6308	6308
q10	8223	2483	2483	2483
q11	425	220	200	200
q12	780	302	320	302
q13	17951	3208	3206	3206
q14	293	279	254	254
q15	539	513	496	496
q16	481	408	435	408
q17	935	896	874	874
q18	6771	6070	6032	6032
q19	1560	1521	1518	1518
q20	551	278	272	272
q21	6562	3464	3567	3464
q22	806	287	285	285
Total cold run time: 106365 ms
Total hot run time: 37895 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4005	3997	3986	3986
q2	303	213	215	213
q3	3001	2943	2911	2911
q4	1861	1817	1832	1817
q5	5107	5126	5099	5099
q6	197	116	117	116
q7	2158	1712	1740	1712
q8	3132	3223	3208	3208
q9	8277	8274	8250	8250
q10	6098	3642	3651	3642
q11	517	430	434	430
q12	703	541	506	506
q13	11387	3058	3068	3058
q14	268	257	260	257
q15	527	497	489	489
q16	515	467	434	434
q17	1712	1680	1679	1679
q18	7909	7514	7353	7353
q19	1685	1647	1642	1642
q20	2101	1900	1886	1886
q21	4742	4628	4588	4588
q22	526	457	438	438
Total cold run time: 66731 ms
Total hot run time: 53714 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169737 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7764f0f5c24d8be00a7161cf4ca6b6ddd5d49bd, data reload: false

query1	945	343	340	340
query2	6536	1782	1913	1782
query3	6698	206	204	204
query4	23091	20603	20535	20535
query5	4290	372	361	361
query6	269	176	173	173
query7	4608	305	305	305
query8	263	191	201	191
query9	8467	2274	2269	2269
query10	423	219	213	213
query11	14494	14307	14236	14236
query12	132	82	82	82
query13	1643	455	446	446
query14	8728	6571	6452	6452
query15	202	176	179	176
query16	7092	257	258	257
query17	1035	520	498	498
query18	1893	272	278	272
query19	187	148	149	148
query20	89	82	83	82
query21	196	129	116	116
query22	4770	4332	4553	4332
query23	30602	29983	30050	29983
query24	11927	3078	3089	3078
query25	642	362	355	355
query26	1794	157	162	157
query27	2976	322	305	305
query28	6969	1847	1840	1840
query29	1180	561	567	561
query30	284	132	139	132
query31	858	698	688	688
query32	100	60	55	55
query33	716	219	235	219
query34	1046	495	495	495
query35	858	750	740	740
query36	920	887	861	861
query37	170	57	64	57
query38	3122	3027	3051	3027
query39	1323	1248	1253	1248
query40	292	102	101	101
query41	40	37	37	37
query42	106	93	99	93
query43	454	440	426	426
query44	1071	714	722	714
query45	188	181	174	174
query46	1040	805	772	772
query47	1513	1481	1392	1392
query48	422	344	375	344
query49	1175	295	294	294
query50	777	373	376	373
query51	4438	4262	4278	4262
query52	102	94	99	94
query53	334	271	270	270
query54	299	232	228	228
query55	92	85	82	82
query56	221	201	205	201
query57	964	869	905	869
query58	217	193	199	193
query59	2248	2223	2171	2171
query60	239	213	231	213
query61	87	86	83	83
query62	599	365	361	361
query63	285	260	257	257
query64	6627	3003	3145	3003
query65	3237	3235	3202	3202
query66	1445	317	320	317
query67	14344	14125	14055	14055
query68	4124	573	563	563
query69	527	380	378	378
query70	1236	1245	1231	1231
query71	324	250	257	250
query72	6035	2834	2668	2668
query73	711	328	321	321
query74	6387	6058	6005	6005
query75	3032	2420	2458	2420
query76	2712	1019	1154	1019
query77	334	237	250	237
query78	8994	8549	8450	8450
query79	2387	518	521	518
query80	1084	361	345	345
query81	505	194	196	194
query82	755	93	88	88
query83	211	127	118	118
query84	273	78	78	78
query85	1651	373	351	351
query86	472	275	295	275
query87	3211	3135	3083	3083
query88	3649	2359	2374	2359
query89	384	370	334	334
query90	1935	164	165	164
query91	153	123	126	123
query92	59	50	46	46
query93	1855	526	517	517
query94	1192	180	179	179
query95	432	333	337	333
query96	570	272	269	269
query97	4270	4156	4134	4134
query98	216	193	201	193
query99	1051	642	646	642
Total cold run time: 265125 ms
Total hot run time: 169737 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7764f0f5c24d8be00a7161cf4ca6b6ddd5d49bd, data reload: false

query1	0.03	0.04	0.03
query2	0.06	0.02	0.02
query3	0.24	0.06	0.06
query4	1.67	0.10	0.10
query5	0.53	0.51	0.51
query6	1.23	0.67	0.66
query7	0.02	0.02	0.01
query8	0.04	0.02	0.02
query9	0.56	0.52	0.55
query10	0.57	0.55	0.58
query11	0.12	0.10	0.10
query12	0.12	0.10	0.10
query13	0.62	0.63	0.61
query14	0.80	0.79	0.79
query15	0.84	0.82	0.81
query16	0.35	0.38	0.38
query17	1.02	0.97	0.96
query18	0.26	0.25	0.25
query19	1.74	1.73	1.71
query20	0.01	0.01	0.02
query21	15.43	0.66	0.63
query22	2.97	3.62	1.95
query23	17.44	1.12	0.99
query24	1.98	0.39	0.37
query25	0.45	0.15	0.06
query26	0.18	0.15	0.17
query27	0.05	0.04	0.04
query28	12.25	0.85	0.82
query29	12.59	3.29	3.31
query30	0.55	0.53	0.53
query31	2.79	0.35	0.36
query32	3.36	0.48	0.48
query33	3.20	3.22	3.23
query34	15.36	4.74	4.75
query35	4.75	4.74	4.72
query36	1.15	1.07	1.08
query37	0.06	0.04	0.04
query38	0.04	0.03	0.03
query39	0.02	0.01	0.01
query40	0.16	0.12	0.13
query41	0.08	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.01
Total cold run time: 105.73 s
Total hot run time: 31.84 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e7764f0f5c24d8be00a7161cf4ca6b6ddd5d49bd with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       15.8 seconds inserted 10000000 Rows, about 632K ops/s

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38165 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a076d048d7f54678df5e7076363878eae598ed8, data reload: false

------ Round 1 ----------------------------------
q1	17643	4103	4072	4072
q2	2047	138	133	133
q3	10679	945	933	933
q4	4694	931	945	931
q5	7636	2947	3003	2947
q6	182	124	123	123
q7	1244	767	757	757
q8	9359	2031	2044	2031
q9	7289	6361	6346	6346
q10	8206	2518	2493	2493
q11	421	217	209	209
q12	723	314	305	305
q13	18006	3227	3217	3217
q14	282	248	251	248
q15	548	501	495	495
q16	467	426	416	416
q17	952	881	851	851
q18	6698	5980	5991	5980
q19	1564	1519	1522	1519
q20	543	279	276	276
q21	6948	3634	3613	3613
q22	813	291	270	270
Total cold run time: 106944 ms
Total hot run time: 38165 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4048	4019	4032	4019
q2	306	216	210	210
q3	2993	2970	2945	2945
q4	1826	1817	1858	1817
q5	5129	5131	5174	5131
q6	198	116	118	116
q7	2156	1726	1716	1716
q8	3146	3213	3225	3213
q9	8312	8276	8245	8245
q10	6219	3670	3656	3656
q11	530	436	426	426
q12	682	543	537	537
q13	3848	3098	3068	3068
q14	294	248	251	248
q15	544	502	494	494
q16	512	463	482	463
q17	1694	1679	1703	1679
q18	7819	7559	7423	7423
q19	1645	1648	1631	1631
q20	2106	1907	1903	1903
q21	4806	4605	4643	4605
q22	510	447	461	447
Total cold run time: 59323 ms
Total hot run time: 53992 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170172 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a076d048d7f54678df5e7076363878eae598ed8, data reload: false

query1	929	352	334	334
query2	6532	1721	1765	1721
query3	6710	206	205	205
query4	23066	20617	20550	20550
query5	4365	366	364	364
query6	262	187	169	169
query7	4602	309	298	298
query8	255	198	217	198
query9	8484	2280	2286	2280
query10	421	221	215	215
query11	14572	14235	14268	14235
query12	139	81	83	81
query13	1635	446	445	445
query14	8302	6864	6912	6864
query15	203	179	174	174
query16	7082	264	252	252
query17	1041	533	508	508
query18	1896	274	269	269
query19	184	145	146	145
query20	89	80	83	80
query21	206	126	125	125
query22	4694	4681	4600	4600
query23	30599	29972	29890	29890
query24	11837	3069	3092	3069
query25	654	354	358	354
query26	1807	153	157	153
query27	2997	321	328	321
query28	6964	1853	1832	1832
query29	1222	567	562	562
query30	284	133	148	133
query31	864	698	706	698
query32	98	61	58	58
query33	708	222	226	222
query34	1060	484	485	484
query35	842	740	762	740
query36	937	889	816	816
query37	172	61	65	61
query38	3108	3004	3002	3002
query39	1289	1254	1261	1254
query40	281	104	100	100
query41	39	36	35	35
query42	100	102	105	102
query43	456	427	413	413
query44	1067	708	728	708
query45	191	181	170	170
query46	1052	791	791	791
query47	1475	1425	1445	1425
query48	427	344	363	344
query49	1163	296	305	296
query50	768	389	390	389
query51	4368	4408	4345	4345
query52	103	86	90	86
query53	338	270	264	264
query54	293	226	223	223
query55	84	84	82	82
query56	217	214	208	208
query57	944	921	902	902
query58	214	196	197	196
query59	2128	2028	2122	2028
query60	239	211	224	211
query61	91	87	92	87
query62	596	368	355	355
query63	274	276	261	261
query64	6510	3085	3184	3085
query65	3312	3233	3193	3193
query66	1446	333	331	331
query67	14642	14284	14034	14034
query68	5008	589	585	585
query69	544	375	386	375
query70	1197	1265	1190	1190
query71	359	249	245	245
query72	6206	2827	2672	2672
query73	712	320	318	318
query74	6335	6065	5976	5976
query75	3023	2459	2419	2419
query76	2789	1048	1169	1048
query77	356	239	243	239
query78	8930	8546	8350	8350
query79	1953	541	521	521
query80	1026	366	344	344
query81	494	198	196	196
query82	939	87	85	85
query83	228	125	122	122
query84	283	78	75	75
query85	1335	382	355	355
query86	403	283	309	283
query87	3292	3086	3177	3086
query88	2860	2352	2343	2343
query89	387	319	343	319
query90	1967	165	165	165
query91	150	148	127	127
query92	57	49	46	46
query93	1614	526	527	526
query94	1269	176	178	176
query95	449	345	351	345
query96	591	275	267	267
query97	4253	4125	4114	4114
query98	220	205	198	198
query99	1096	637	641	637
Total cold run time: 264254 ms
Total hot run time: 170172 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a076d048d7f54678df5e7076363878eae598ed8, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.67	0.09	0.10
query5	0.52	0.52	0.52
query6	1.39	0.67	0.68
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.55	0.52	0.51
query10	0.57	0.56	0.57
query11	0.12	0.10	0.10
query12	0.13	0.10	0.10
query13	0.62	0.60	0.60
query14	0.79	0.82	0.81
query15	0.83	0.82	0.82
query16	0.37	0.37	0.38
query17	1.01	1.00	0.97
query18	0.27	0.26	0.25
query19	1.77	1.73	1.77
query20	0.01	0.01	0.02
query21	15.43	0.64	0.63
query22	3.33	3.63	2.45
query23	17.46	0.99	0.94
query24	1.99	0.78	0.21
query25	0.41	0.15	0.07
query26	0.19	0.16	0.18
query27	0.05	0.05	0.04
query28	12.05	0.85	0.84
query29	12.55	3.21	3.21
query30	0.60	0.54	0.53
query31	2.78	0.36	0.35
query32	3.35	0.49	0.48
query33	3.23	3.23	3.21
query34	15.35	4.76	4.73
query35	4.76	4.79	4.77
query36	1.12	1.08	1.06
query37	0.06	0.05	0.05
query38	0.04	0.03	0.03
query39	0.01	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.01	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 106.05 s
Total hot run time: 32.21 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1a076d048d7f54678df5e7076363878eae598ed8 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       16.4 seconds inserted 10000000 Rows, about 609K ops/s

Vallishp
Vallishp approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Vallishp Vallishp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 27, 2024
@yiguolei yiguolei merged commit 1066192 into apache:master Feb 27, 2024
28 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Feb 28, 2024
@xinyiZzz @Doris-Extras
[opt](plsql) Fix procedure key compatibility (#31445)
c075458 
use dbId replace dbName, because dbName may be renamed by Alter.
procedure key add package name (only reserved, currently no plans to support package)
Optimize procedure create and exception
seawinde pushed a commit to seawinde/doris that referenced this pull request Feb 28, 2024
@xinyiZzz @seawinde
[opt](plsql) Fix procedure key compatibility (apache#31445)
0f54513 
use dbId replace dbName, because dbName may be renamed by Alter.
procedure key add package name (only reserved, currently no plans to support package)
Optimize procedure create and exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@Vallishp Vallishp Vallishp approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. meta-change reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinyiZzz @doris-robot @yiguolei @Vallishp