Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](function) support cosh math function #30602

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[feature](function) support cosh math function #30602

merged 1 commit into from
Jan 31, 2024

Conversation

rohitrs1983
Copy link
Contributor

Proposed changes

Issue Number: close #30601

support cosh math function.
image

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor

run buildall

HappenLee
HappenLee approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37038 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc04e6698dce042388a677a970beea04442cb6d3, data reload: false

------ Round 1 ----------------------------------
q1	17746	4997	4441	4441
q2	2155	140	146	140
q3	11548	943	937	937
q4	6376	760	744	744
q5	7916	2836	2912	2836
q6	197	122	122	122
q7	1161	747	724	724
q8	9422	2039	2087	2039
q9	7189	6318	6283	6283
q10	8073	2407	2453	2407
q11	408	211	216	211
q12	790	274	263	263
q13	17987	3315	3301	3301
q14	269	250	245	245
q15	523	495	493	493
q16	480	397	400	397
q17	934	534	516	516
q18	6762	6125	5940	5940
q19	1569	1374	1349	1349
q20	575	310	320	310
q21	6807	3040	3096	3040
q22	807	309	300	300
Total cold run time: 109694 ms
Total hot run time: 37038 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4473	4408	4433	4408
q2	334	231	250	231
q3	3048	2832	2835	2832
q4	1874	1679	1666	1666
q5	5213	5230	5256	5230
q6	188	114	114	114
q7	2218	1766	1799	1766
q8	3118	3225	3254	3225
q9	8437	8371	8275	8275
q10	5820	3584	3584	3584
q11	550	452	474	452
q12	757	590	595	590
q13	7276	3140	3108	3108
q14	276	250	264	250
q15	544	490	488	488
q16	527	479	480	479
q17	1858	1710	1727	1710
q18	7918	7888	7568	7568
q19	7325	1502	1436	1436
q20	2135	1924	1895	1895
q21	4696	4591	4625	4591
q22	534	445	443	443
Total cold run time: 69119 ms
Total hot run time: 54341 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172407 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc04e6698dce042388a677a970beea04442cb6d3, data reload: false

query1	931	335	326	326
query2	6555	2036	1818	1818
query3	6701	199	198	198
query4	27063	22082	22187	22082
query5	4448	418	401	401
query6	247	153	156	153
query7	4607	274	264	264
query8	250	175	178	175
query9	9004	2291	2259	2259
query10	414	204	199	199
query11	16945	15355	15274	15274
query12	120	69	62	62
query13	1679	372	366	366
query14	9199	6468	6455	6455
query15	242	176	186	176
query16	6516	250	241	241
query17	1912	476	460	460
query18	1927	269	247	247
query19	200	132	134	132
query20	71	66	64	64
query21	194	135	131	131
query22	4933	4693	4698	4693
query23	31387	30149	30258	30149
query24	12291	2758	2754	2754
query25	585	304	306	304
query26	1975	134	137	134
query27	2990	286	283	283
query28	7684	1843	1836	1836
query29	2164	618	630	618
query30	287	135	140	135
query31	929	708	721	708
query32	93	51	48	48
query33	710	203	206	203
query34	1124	466	474	466
query35	866	757	776	757
query36	1318	1119	1187	1119
query37	175	56	59	56
query38	3265	3122	3136	3122
query39	1309	1257	1237	1237
query40	324	83	82	82
query41	37	33	36	33
query42	91	86	76	76
query43	512	460	500	460
query44	1107	685	688	685
query45	191	181	175	175
query46	1060	638	629	629
query47	1596	1503	1494	1494
query48	385	305	302	302
query49	1270	280	280	280
query50	673	310	308	308
query51	5220	5110	5131	5110
query52	91	82	73	73
query53	314	263	271	263
query54	264	178	182	178
query55	80	73	76	73
query56	165	166	158	158
query57	993	914	919	914
query58	200	152	157	152
query59	2456	2475	2408	2408
query60	202	171	177	171
query61	82	82	88	82
query62	658	352	366	352
query63	274	274	252	252
query64	5628	1752	1736	1736
query65	3264	3192	3204	3192
query66	1484	325	314	314
query67	14347	14101	14064	14064
query68	4431	503	500	500
query69	446	308	301	301
query70	1497	1561	1534	1534
query71	294	210	221	210
query72	3724	2842	2843	2842
query73	680	311	315	311
query74	6654	6222	6244	6222
query75	2814	2296	2311	2296
query76	2910	949	956	949
query77	326	231	233	231
query78	9061	8655	8520	8520
query79	2937	486	525	486
query80	1819	308	310	308
query81	522	199	199	199
query82	876	83	78	78
query83	424	120	125	120
query84	281	77	77	77
query85	1767	343	325	325
query86	484	362	401	362
query87	3433	3237	3286	3237
query88	3842	2168	2157	2157
query89	425	368	368	368
query90	1959	181	175	175
query91	143	114	140	114
query92	56	41	45	41
query93	2250	448	416	416
query94	1306	158	156	156
query95	499	455	433	433
query96	620	326	309	309
query97	4224	4104	4129	4104
query98	215	190	184	184
query99	1096	721	735	721
Total cold run time: 278293 ms
Total hot run time: 172407 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc04e6698dce042388a677a970beea04442cb6d3, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.02
query3	0.22	0.06	0.06
query4	1.67	0.10	0.09
query5	0.53	0.52	0.51
query6	1.24	0.63	0.64
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.49
query10	0.56	0.55	0.56
query11	0.11	0.08	0.09
query12	0.11	0.09	0.10
query13	0.59	0.62	0.60
query14	0.77	0.80	0.80
query15	0.80	0.76	0.78
query16	0.39	0.37	0.35
query17	1.02	1.00	1.01
query18	0.24	0.28	0.23
query19	1.84	1.73	1.80
query20	0.02	0.01	0.01
query21	15.41	0.56	0.58
query22	2.35	2.75	2.19
query23	17.27	0.80	0.86
query24	2.58	1.04	1.17
query25	0.33	0.21	0.05
query26	0.60	0.13	0.13
query27	0.06	0.04	0.05
query28	10.97	0.84	0.82
query29	12.52	3.27	3.10
query30	0.63	0.49	0.56
query31	2.79	0.34	0.34
query32	3.37	0.49	0.48
query33	3.22	3.20	3.26
query34	15.91	4.22	4.30
query35	4.29	4.33	4.28
query36	1.09	1.05	1.08
query37	0.07	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.13	0.13
query41	0.07	0.01	0.01
query42	0.02	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.62 s
Total hot run time: 31.11 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit dc04e6698dce042388a677a970beea04442cb6d3 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.6 seconds inserted 10000000 Rows, about 735K ops/s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.19% (8626/23834)
Line Coverage: 28.25% (70540/249707)
Region Coverage: 27.25% (36403/133592)
Branch Coverage: 24.04% (18643/77566)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dc04e6698dce042388a677a970beea04442cb6d3_dc04e6698dce042388a677a970beea04442cb6d3/report/index.html

@yiguolei yiguolei merged commit df6d7a2 into apache:master Jan 31, 2024
26 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Jan 31, 2024
@rohitrs1983 @Doris-Extras
support cosh math function (#30602)
2995da0 
Co-authored-by: Rohit Satardekar <rohitrs1983@gmail.com>
yiguolei pushed a commit that referenced this pull request Jan 31, 2024
@rohitrs1983 @Doris-Extras
support cosh math function (#30602)
792d74a 
Co-authored-by: Rohit Satardekar <rohitrs1983@gmail.com>
yiguolei pushed a commit that referenced this pull request Jan 31, 2024
@rohitrs1983 @Doris-Extras
support cosh math function (#30602)
19f57b5 
Co-authored-by: Rohit Satardekar <rohitrs1983@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support cosh math function
4 participants
@rohitrs1983 @HappenLee @doris-robot @yiguolei