-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](index compaction) Support merge null_bitmap during index compaction #30352
Conversation
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 50059 ms
|
TPC-DS: Total hot run time: 241169 ms
|
ClickBench: Total hot run time: 30.6 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
TeamCity be ut coverage result: |
1265a89
to
bc90a78
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 49824 ms
|
TPC-DS: Total hot run time: 239109 ms
|
ClickBench: Total hot run time: 30.69 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
…tion Spport merge null_bitmap during index compaction. We read the source indices null_bitmap files and write them to new ones according to the translation vector doc id mapping. fix cl_test compile error
bc90a78
to
09065f8
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 49945 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 235540 ms
|
ClickBench: Total hot run time: 30.82 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run p0 |
1 similar comment
run p0 |
Proposed changes
pick #30326
null_bitmap
file is not considered in index compaction process. This will lead wrong query result when doc is containNULL
values.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...