-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](cmake) Refactor be CMakeLists ENABLE_CLANG_COVERAGE CMAKE_CXX_FLAGS byadd_compile_options #30333
Merged
jackwener
merged 1 commit into
apache:master
from
JackDrogon:refactor/be_cmake_coverage_flag
Jan 25, 2024
Merged
[refactor](cmake) Refactor be CMakeLists ENABLE_CLANG_COVERAGE CMAKE_CXX_FLAGS byadd_compile_options #30333
jackwener
merged 1 commit into
apache:master
from
JackDrogon:refactor/be_cmake_coverage_flag
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_compile_options Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
clang-tidy review says "All clean, LGTM! 👍" |
Lchangliang
approved these changes
Jan 24, 2024
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Jan 24, 2024
PR approved by at least one committer and no changes requested. |
run buildall |
TPC-H: Total hot run time: 38352 ms
|
TPC-DS: Total hot run time: 188780 ms
|
ClickBench: Total hot run time: 30.47 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
jackwener
approved these changes
Jan 25, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jan 25, 2024
…CXX_FLAGS byadd_compile_options (#30333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactor be CMakeLists ENABLE_CLANG_COVERAGE CMAKE_CXX_FLAGS by add_compile_options
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...