Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](cmake) Refactor be CMakeLists ENABLE_CLANG_COVERAGE CMAKE_CXX_FLAGS byadd_compile_options #30333

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

JackDrogon
Copy link
Contributor

Proposed changes

Refactor be CMakeLists ENABLE_CLANG_COVERAGE CMAKE_CXX_FLAGS by add_compile_options

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

add_compile_options

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@JackDrogon
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8448256a8f2187f36e3199f9099ca52398e32f44, data reload: false

------ Round 1 ----------------------------------
q1	17620	5389	5182	5182
q2	2035	135	141	135
q3	10788	1164	1174	1164
q4	10383	745	879	745
q5	7745	3114	3062	3062
q6	197	122	119	119
q7	853	491	482	482
q8	9212	1918	1930	1918
q9	7218	6332	6346	6332
q10	8176	3025	2986	2986
q11	415	210	210	210
q12	350	187	184	184
q13	17999	3369	3333	3333
q14	239	218	208	208
q15	540	503	504	503
q16	427	367	365	365
q17	929	506	484	484
q18	7608	7012	6642	6642
q19	1930	1412	1387	1387
q20	614	309	271	271
q21	2755	2346	2382	2346
q22	341	314	294	294
Total cold run time: 108374 ms
Total hot run time: 38352 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5498	5187	5368	5187
q2	322	218	210	210
q3	3323	3238	3228	3228
q4	2024	2039	2010	2010
q5	6001	5909	5772	5772
q6	197	116	116	116
q7	2275	1824	1922	1824
q8	3213	3328	3352	3328
q9	8829	8796	8734	8734
q10	3935	3843	3827	3827
q11	550	483	440	440
q12	812	631	619	619
q13	16900	3125	3117	3117
q14	271	251	277	251
q15	548	491	504	491
q16	525	462	478	462
q17	1836	1788	1873	1788
q18	9398	9342	11745	9342
q19	22678	1594	1510	1510
q20	4412	1932	1914	1914
q21	13177	5395	5408	5395
q22	981	568	570	568
Total cold run time: 107705 ms
Total hot run time: 60133 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188780 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8448256a8f2187f36e3199f9099ca52398e32f44, data reload: false

query1	1107	338	333	333
query2	6658	2210	2035	2035
query3	6708	207	205	205
query4	31876	22470	22362	22362
query5	4550	391	397	391
query6	259	166	182	166
query7	6220	280	271	271
query8	245	179	198	179
query9	8541	2699	2689	2689
query10	416	237	248	237
query11	17231	15875	15622	15622
query12	128	70	66	66
query13	1709	387	388	387
query14	12485	7142	7183	7142
query15	222	185	189	185
query16	5808	262	249	249
query17	947	466	461	461
query18	1788	261	255	255
query19	181	133	127	127
query20	75	73	71	71
query21	193	134	130	130
query22	4927	4842	4802	4802
query23	32201	31780	31833	31780
query24	13419	2890	2875	2875
query25	577	319	298	298
query26	1837	142	150	142
query27	3149	297	298	297
query28	8969	1856	1854	1854
query29	2726	664	653	653
query30	285	137	143	137
query31	951	763	783	763
query32	76	54	51	51
query33	712	215	210	210
query34	1236	488	497	488
query35	908	774	793	774
query36	1339	1241	1212	1212
query37	175	59	55	55
query38	3396	3222	3249	3222
query39	1310	1264	1285	1264
query40	344	93	85	85
query41	38	34	34	34
query42	87	89	78	78
query43	526	487	499	487
query44	1074	688	694	688
query45	193	180	174	174
query46	1056	646	669	646
query47	1680	1600	1545	1545
query48	386	330	309	309
query49	1224	294	298	294
query50	682	314	317	314
query51	5334	5176	5258	5176
query52	93	79	74	74
query53	325	253	266	253
query54	242	185	179	179
query55	79	74	73	73
query56	184	161	162	161
query57	1048	905	937	905
query58	185	159	169	159
query59	2966	2643	2719	2643
query60	211	174	181	174
query61	81	79	80	79
query62	613	371	364	364
query63	289	257	264	257
query64	6115	1824	1740	1740
query65	3333	3250	3262	3250
query66	1441	324	317	317
query67	15565	15136	15272	15136
query68	10574	530	520	520
query69	592	322	301	301
query70	1659	1529	1476	1476
query71	10473	10207	10202	10202
query72	4137	2815	2831	2815
query73	1952	319	327	319
query74	7503	6359	6371	6359
query75	4909	2376	2326	2326
query76	7304	1070	1021	1021
query77	846	225	231	225
query78	9070	8904	8603	8603
query79	1009	496	493	493
query80	715	320	313	313
query81	483	205	206	205
query82	294	80	78	78
query83	174	115	115	115
query84	286	67	71	67
query85	1179	326	334	326
query86	393	405	363	363
query87	3491	3341	3318	3318
query88	2995	2214	2209	2209
query89	429	355	349	349
query90	2230	185	188	185
query91	162	125	131	125
query92	52	44	45	44
query93	1227	451	443	443
query94	1287	161	155	155
query95	504	461	470	461
query96	612	326	314	314
query97	4250	4120	4140	4120
query98	212	199	184	184
query99	1079	712	721	712
Total cold run time: 313016 ms
Total hot run time: 188780 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8448256a8f2187f36e3199f9099ca52398e32f44, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.02	0.02
query3	0.23	0.05	0.05
query4	1.68	0.07	0.08
query5	0.55	0.53	0.52
query6	1.33	0.61	0.64
query7	0.02	0.02	0.01
query8	0.03	0.02	0.02
query9	0.54	0.50	0.51
query10	0.54	0.55	0.56
query11	0.12	0.09	0.09
query12	0.12	0.10	0.10
query13	0.60	0.60	0.61
query14	0.81	0.78	0.84
query15	0.80	0.78	0.79
query16	0.38	0.38	0.36
query17	0.99	0.99	0.98
query18	0.23	0.26	0.24
query19	1.85	1.79	1.80
query20	0.01	0.01	0.02
query21	15.40	0.57	0.57
query22	2.50	2.08	1.63
query23	17.37	0.78	0.74
query24	3.14	0.84	0.83
query25	0.41	0.24	0.15
query26	0.47	0.14	0.13
query27	0.05	0.04	0.06
query28	10.95	0.80	0.78
query29	12.48	3.28	3.11
query30	0.55	0.50	0.45
query31	2.78	0.34	0.36
query32	3.37	0.48	0.49
query33	3.24	3.23	3.25
query34	15.81	4.33	4.28
query35	4.25	4.30	4.29
query36	1.11	1.06	1.08
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.01	0.01
query40	0.16	0.13	0.13
query41	0.06	0.02	0.01
query42	0.03	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 105.21 s
Total hot run time: 30.47 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 8448256a8f2187f36e3199f9099ca52398e32f44 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       14.2 seconds inserted 10000000 Rows, about 704K ops/s

@jackwener jackwener merged commit cb9cfcf into apache:master Jan 25, 2024
30 of 31 checks passed
yiguolei pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants