Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs](ip function) add ipv4/v6 datatype and some ip functions' docs #30194

Merged
merged 10 commits into from
Jan 22, 2024

Conversation

sjyango
Copy link
Contributor

@sjyango sjyango commented Jan 21, 2024

Proposed changes

Issue Number: close #xxx

Add some docs for ipv4/ipv6 datatype and some ip functions, such as:

  • ipv4_cidr_to_range
  • ipv6_cidr_to_range
  • is_ip_address_in_range
  • is_ipv4_string
  • is_ipv6_string
  • to_ipv4
  • to_ipv4_or_default
  • to_ipv4_or_null
  • to_ipv6
  • to_ipv6_or_default
  • to_ipv6_or_null

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 22, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee
Copy link
Contributor

run buildall

@yiguolei yiguolei merged commit f124a78 into apache:master Jan 22, 2024
27 of 28 checks passed
@sjyango sjyango deleted the ip-doc branch January 30, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants