-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimize](invert index) avoid redundant checks for exist. #30191
Conversation
run buildall |
TPC-H: Total hot run time: 39104 ms
|
TPC-DS: Total hot run time: 176580 ms
|
ClickBench: Total hot run time: 30.95 s
|
clang-tidy review says "All clean, LGTM! 👍" |
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
@@ -145,6 +145,14 @@ Status InvertedIndexSearcherCache::get_index_searcher( | |||
return Status::OK(); | |||
} | |||
|
|||
// check index file existence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 162 below also checks index exists
787f711
to
e088152
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37814 ms
|
TPC-DS: Total hot run time: 173234 ms
|
ClickBench: Total hot run time: 30.36 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
e088152
to
09015c6
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37590 ms
|
TPC-DS: Total hot run time: 173940 ms
|
ClickBench: Total hot run time: 31.41 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...