[fix](kerberos) optimize kerbero options, remove BE kinit, just use UGI login by newInstanceFromKeytab #29291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsjz
changed the title
wsjz
changed the title
morningman
reviewed
Jan 12, 2024
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -105,7 +104,9 @@ class HdfsFileHandleCache { | |||
|
|
|||
| private: | |||
| FileHandleCache _cache; | |||
| HdfsFileHandleCache() : _cache(config::max_hdfs_file_handle_cache_num, 16, 3600 * 1000L) {} | |||
| HdfsFileHandleCache() | |||
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/io/fs/hdfs_file_system.cpp:108:
- config::max_hdfs_file_handle_cache_time_sec * 1000L) {};
+ config::max_hdfs_file_handle_cache_time_sec * 1000L) = default;;
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39283 ms |
TPC-DS: Total hot run time: 179629 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
ClickBench: Total hot run time: 30.26 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
approved these changes
Jan 12, 2024
yiguolei
approved these changes
Jan 12, 2024
xiaokang
pushed a commit
that referenced
this pull request
Jan 12, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 15, 2024
apache#29291) 1. we need remove BE kinit, and use jni login with keytab, because kinit cannot renew TGT for doris in many complex cases. > This pull requet will support new instance from keytab: apache/doris-thirdparty#173, so now we won't need kinit cmd, just login with keytab and principal 2. add `kerberos_ccache_path` to set kerberos credentials cache path manually. 3. add `max_hdfs_file_handle_cache_time_ms` to set hdfs fs handle cache time.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 15, 2024
apache#29291) 1. we need remove BE kinit, and use jni login with keytab, because kinit cannot renew TGT for doris in many complex cases. > This pull requet will support new instance from keytab: apache/doris-thirdparty#173, so now we won't need kinit cmd, just login with keytab and principal 2. add `kerberos_ccache_path` to set kerberos credentials cache path manually. 3. add `max_hdfs_file_handle_cache_time_ms` to set hdfs fs handle cache time.
yiguolei
pushed a commit
that referenced
this pull request
Jan 16, 2024
#29291) 1. we need remove BE kinit, and use jni login with keytab, because kinit cannot renew TGT for doris in many complex cases. > This pull requet will support new instance from keytab: apache/doris-thirdparty#173, so now we won't need kinit cmd, just login with keytab and principal 2. add `kerberos_ccache_path` to set kerberos credentials cache path manually. 3. add `max_hdfs_file_handle_cache_time_ms` to set hdfs fs handle cache time.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Jan 22, 2024
…o options (apache#29291)" This reverts commit df30de0.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Jan 30, 2024
…o options (apache#29291)" This reverts commit df30de0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
add
kerberos_ccache_pathto set kerberos credentials cache path manually.add
max_hdfs_file_handle_cache_time_msto set hdfs fs handle cache time.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...