Add sync_dir interface to Env
#2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we need to ensure that **a newly-created file** is fully synchronized back to disk, we should call `fsync()` on the parent directory—that is, the directory containing the newly-created file. That is to say, In this situation, we should call `fsync()` on both the newly-created file and its parent directory. Unfortunately, currently in Doris, in any scenario, directories are not fsynced. This patch adds `sync_dir()` interface first, laying the goundwork for future fixes. This patch also remove unneeded private method `dir_exists()`.
chaoyli
requested changes
Feb 12, 2020
chaoyli
approved these changes
Feb 12, 2020
lingbin
added
kind/improvement
area/storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we need to ensure that a newly-created file is fully
synchronized back to disk, we should call
fsync()on the parentdirectory—that is, the directory containing the newly-created file.
That is to say, In this situation, we should call
fsync()onboth the newly-created file and its parent directory.
Unfortunately, currently in Doris, in any scenario, directories
are not fsynced.
This patch adds
sync_dir()interface first, laying the goundworkfor future fixes.
This patch also remove unneeded private method
dir_exists().