Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Outfile) The Struct type data exported from select outfile to the csv file format should contain a column name #28068

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Dec 6, 2023

Proposed changes

Issue Number: close #xxx

If the original data is:

+-----------------------------------------------------+
| s_info                                              |
+-----------------------------------------------------+
| {"s_id": 2, "s_name": "nereids", "s_address": "20"} |
| {"s_id": 1, "s_name": "doris", "s_address": "18"}   |
+-----------------------------------------------------+

In the original logic, the struct type data exported to a csv file format did not contain column names,like

{2, "nereids", "20"} 
{1, "doris", "18"}

This pr do not need to be merged into branch-2.0

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BePPPower
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Dec 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.7 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17165239720 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 1a45bb778ffa8001c3f464181b2aba1f7218c4c4, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4673	4420	4416	4416
q2	376	180	157	157
q3	1457	1259	1243	1243
q4	1111	903	915	903
q5	3176	3204	3223	3204
q6	249	128	126	126
q7	998	507	491	491
q8	2228	2226	2204	2204
q9	6645	6729	6866	6729
q10	3238	3256	3279	3256
q11	333	211	208	208
q12	358	208	209	208
q13	4566	3781	3792	3781
q14	245	211	219	211
q15	566	531	528	528
q16	443	397	389	389
q17	998	640	566	566
q18	7383	7111	7037	7037
q19	1519	1470	1341	1341
q20	561	332	329	329
q21	3112	2708	2730	2708
q22	360	284	303	284
Total cold run time: 44595 ms
Total hot run time: 40319 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4336	4379	4342	4342
q2	271	165	173	165
q3	3531	3511	3504	3504
q4	2393	2376	2373	2373
q5	5744	5735	5759	5735
q6	239	121	124	121
q7	2364	1867	1869	1867
q8	3514	3514	3537	3514
q9	9098	9010	9047	9010
q10	3896	3973	3998	3973
q11	507	373	396	373
q12	760	581	606	581
q13	4291	3586	3540	3540
q14	283	259	260	259
q15	574	523	521	521
q16	497	434	495	434
q17	1871	1850	1884	1850
q18	8666	8274	8197	8197
q19	1722	1760	1741	1741
q20	2238	1936	1942	1936
q21	6507	6155	6143	6143
q22	489	433	408	408
Total cold run time: 63791 ms
Total hot run time: 60587 ms

@morningman morningman added not-merge/2.0 do not merge into 2.0 branch and removed dev/2.0.4 labels Dec 6, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 3dcbf16 into apache:master Dec 7, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…he csv file format should contain a column name apache#28068

If the original data is:
```sql
+-----------------------------------------------------+
| s_info                                              |
+-----------------------------------------------------+
| {"s_id": 2, "s_name": "nereids", "s_address": "20"} |
| {"s_id": 1, "s_name": "doris", "s_address": "18"}   |
+-----------------------------------------------------+
```

In the original logic, the struct type data exported to a csv file format did not contain column names,like
```
{2, "nereids", "20"} 
{1, "doris", "18"}
```

This pr do not need to be merged into branch-2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/behavior-changed not-merge/2.0 do not merge into 2.0 branch reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants