Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix core when es_scanner_node exit #2634

Merged
merged 1 commit into from
Jan 2, 2020
Merged

fix core when es_scanner_node exit #2634

merged 1 commit into from
Jan 2, 2020

Conversation

BabySid
Copy link
Contributor

@BabySid BabySid commented Jan 2, 2020

wuyunfeng
wuyunfeng reviewed Jan 2, 2020
View reviewed changes
be/src/exec/es_http_scan_node.cpp
@@ -166,7 +166,7 @@ Status EsHttpScanNode::start_scanners() {
}

Status EsHttpScanNode::collect_scanners_status() {
for (int i = 0; i < _scan_ranges.size(); i++) {
for (int i = 0; i < _scanners_status.size(); i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments for this modifaction?

wuyunfeng
wuyunfeng approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@wuyunfeng wuyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments

imay
imay approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit d05768f into apache:master Jan 2, 2020
infearOnTheWay pushed a commit to infearOnTheWay/incubator-doris that referenced this pull request Jan 6, 2020
@BabySid @infearOnTheWay
Fix core when es_scanner_node exit (apache#2634)
a82930a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

@wuyunfeng wuyunfeng wuyunfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BabySid @imay @wuyunfeng