Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](meta) Add thrift rpc to get db/table/backend meta #25943

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[feature](meta) Add thrift rpc to get db/table/backend meta #25943

merged 2 commits into from
Oct 27, 2023

Conversation

JackDrogon
Copy link
Contributor

Proposed changes

Add thrift get db/table/backend meta

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JackDrogon
Add thrift get db/table/backend meta
e0aa418 
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.96 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162263143 Bytes

@JackDrogon
Fix style
70fdf7b 
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.67 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161803462 Bytes

dataroaring
dataroaring approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit fa06c75 into apache:master Oct 27, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@JackDrogon
[feature](meta) Add thrift rpc to get db/table/backend meta (apache#2…
6ddfbc3 
…5943)


Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
JackDrogon added a commit to JackDrogon/doris that referenced this pull request Nov 2, 2023
@JackDrogon
[feature](meta) Add thrift rpc to get db/table/backend meta (apache#2…
02bcc94 
…5943)

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon JackDrogon mentioned this pull request Nov 2, 2023
Merged
xiaokang pushed a commit that referenced this pull request Nov 2, 2023
@JackDrogon
[feature](meta) Add thrift rpc to get db/table/backend meta (#25943) (#…
fe63d42 
…26286)
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@JackDrogon
[feature](meta) Add thrift rpc to get db/table/backend meta (apache#2…
daf2a3f 
…5943) (apache#26286)
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@JackDrogon
[feature](meta) Add thrift rpc to get db/table/backend meta (apache#2…
8548656 
…5943)


Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w41ter w41ter w41ter approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackDrogon @doris-robot @w41ter @dataroaring @xiaokang