Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](delete) fix potential delete fail after adding columns #25817

Merged
merged 3 commits into from
Oct 24, 2023
Merged

[fix](delete) fix potential delete fail after adding columns #25817

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30a91f0
fix potential delete fail after adding column
TangSiyang2001 Oct 24, 2023
e8c11cb
use column id explicitly
TangSiyang2001 Oct 24, 2023
a391814
move check to delete handler
TangSiyang2001 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/olap/push_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ Status PushHandler::_do_streaming_ingestion(TabletSharedPtr tablet, const TPushR
// TODO(tsy): make it fail here after FE forbidding hard-link-schema-change
continue;
}
if (tablet_schema.field_index(delete_cond.column_unique_id) == -1) {
if (tablet_schema.columns()[0].unique_id() < 0) {
const auto& err_msg =
fmt::format("column id={} does not exists, table id={}",
delete_cond.column_unique_id, tablet_schema.table_id());
fmt::format("column id does not exists in tablet={}, schema version={},",
tablet->tablet_id(), tablet_schema.schema_version());
return Status::Aborted(err_msg);
}
if (!iequal(tablet_schema.column_by_uid(delete_cond.column_unique_id).name(),
Expand Down