[Performance](sink) SIMD the tablet sink valied data function #25480
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -66,15 +66,15 @@ class OlapTableBlockConvertor { | |||
|
|
|||
| Status _validate_column(RuntimeState* state, const TypeDescriptor& type, bool is_nullable, | |||
| vectorized::ColumnPtr column, size_t slot_index, bool* stop_processing, | |||
| fmt::memory_buffer& error_prefix, | |||
| fmt::memory_buffer& error_prefix, const uint32_t row_count, | |||
There was a problem hiding this comment.
warning: parameter 'row_count' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| fmt::memory_buffer& error_prefix, const uint32_t row_count, | |
| fmt::memory_buffer& error_prefix, uint32_t row_count, |
There was a problem hiding this comment.
Remove this const in header file.
| vectorized::IColumn::Permutation* rows = nullptr); | ||
|
|
||
| // make input data valid for OLAP table | ||
| // return number of invalid/filtered rows. | ||
| // invalid row number is set in Bitmap | ||
| // set stop_processing if we want to stop the whole process now. | ||
| Status _validate_data(RuntimeState* state, vectorized::Block* block, int64_t& filtered_rows, | ||
| bool* stop_processing); | ||
| Status _validate_data(RuntimeState* state, vectorized::Block* block, const uint32_t rows, |
There was a problem hiding this comment.
warning: parameter 'rows' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| Status _validate_data(RuntimeState* state, vectorized::Block* block, const uint32_t rows, | |
| Status _validate_data(RuntimeState* state, vectorized::Block* block, uint32_t rows, |
There was a problem hiding this comment.
Remove this const in header file.
HappenLee
changed the title
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Proposed changes
Before：4.5s
after：1s
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...