-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](meta) allow to ignore unknown image module #25450
[improvement](meta) allow to ignore unknown image module #25450
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
throw new IOException("Unknown meta module: " + metaIndex.name + ". Known modules: " | ||
+ PersistMetaModules.MODULE_NAMES); | ||
if (Config.ignore_unknown_metadata_module) { | ||
LOG.warn("meta modules {} is unknown, ignore and skip it"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget use module names for '{}' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
3014c49
to
cf2a099
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
PR approved by at least one committer and no changes requested. |
Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
…5968) Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
… (apache#25968) Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
2.schame_pb cache 3.json escape optimize 4.ignore unknown module: apache#25450 5.add index_writer::add_null_document interface
Add new FE config `ignore_unknown_metadata_module`. Default is false. If set to true, when reading metadata image file, and there are unknown modules, these modules will be ignored and skipped. This is mainly used in downgrade operation, old version can be compatible with new version Image file.
Proposed changes
Add new FE config
ignore_unknown_metadata_module
. Default is false.If set to true, when reading metadata image file, and there are unknown modules, these modules
will be ignored and skipped.
This is mainly used in downgrade operation, old version can be compatible with new version Image file.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...