Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thirdparty](import) import avx2neon library #25383

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[thirdparty](import) import avx2neon library #25383

merged 1 commit into from
Oct 23, 2023

Conversation

zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.03 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162156079 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8145/22446)
Line Coverage: 28.42% (65257/229589)
Region Coverage: 27.10% (33800/124726)
Branch Coverage: 23.89% (17248/72202)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ef15015d2bbe14ad34206d8deb3e8d52ebba6f8a_ef15015d2bbe14ad34206d8deb3e8d52ebba6f8a/report/index.html

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.91 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162240386 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8145/22446)
Line Coverage: 28.43% (65263/229589)
Region Coverage: 27.10% (33795/124726)
Branch Coverage: 23.89% (17247/72202)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69ce438b44e86835fb8bf9931bab5d3a9dfa24d2_69ce438b44e86835fb8bf9931bab5d3a9dfa24d2/report/index.html

HappenLee
HappenLee previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 15, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.64% (8228/22456)
Line Coverage: 28.78% (65939/229131)
Region Coverage: 27.48% (34194/124421)
Branch Coverage: 24.20% (17412/71952)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e74759ebcc782e4e66415f6bc7299ef1c8fc7f37_e74759ebcc782e4e66415f6bc7299ef1c8fc7f37/report/index.html

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.64% (8228/22456)
Line Coverage: 28.78% (65941/229131)
Region Coverage: 27.49% (34204/124421)
Branch Coverage: 24.20% (17413/71952)
Coverage Report: http://coverage.selectdb-in.cc/coverage/48caa0f647741ed95dc6de5589d90aaf44f1b9e0_48caa0f647741ed95dc6de5589d90aaf44f1b9e0/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.61 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162265772 Bytes

@zclllyybb zclllyybb force-pushed the avxtoneon branch 2 times, most recently from 55bbd97 to ec6ec1f Compare October 16, 2023 08:49
@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.69% (8228/22423)
Line Coverage: 28.84% (65937/228622)
Region Coverage: 27.54% (34192/124160)
Branch Coverage: 24.25% (17406/71782)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec6ec1f48a039c5ebd6332b0fc0528e9695ef677_ec6ec1f48a039c5ebd6332b0fc0528e9695ef677/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.84 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17161858079 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.4 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162320146 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.03% (8284/22371)
Line Coverage: 29.09% (66452/228461)
Region Coverage: 27.74% (34503/124380)
Branch Coverage: 24.35% (17532/72008)
Coverage Report: http://coverage.selectdb-in.cc/coverage/68779abee558f90053b3ff7d2d6f4e3204f258d8_68779abee558f90053b3ff7d2d6f4e3204f258d8/report/index.html

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.03% (8284/22371)
Line Coverage: 29.08% (66447/228461)
Region Coverage: 27.74% (34504/124384)
Branch Coverage: 24.35% (17532/72012)
Coverage Report: http://coverage.selectdb-in.cc/coverage/930f9aa14eb158cda3445acf206cb78aabc5cfa9_930f9aa14eb158cda3445acf206cb78aabc5cfa9/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.8 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162084156 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.97% (8283/22405)
Line Coverage: 29.06% (66437/228617)
Region Coverage: 27.72% (34491/124432)
Branch Coverage: 24.33% (17524/72016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/19efdb9caeaffbc39f0352f745e0148d373a2762_19efdb9caeaffbc39f0352f745e0148d373a2762/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.92 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162617518 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

HappenLee
HappenLee approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit 4889841 into apache:master Oct 23, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@zclllyybb
[thirdparty](import) import avx2neon library (apache#25383)
57777dd 
 import avx2neon library
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@zclllyybb
[thirdparty](import) import avx2neon library (apache#25383)
5c886a2 
 import avx2neon library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zclllyybb @doris-robot @BiteTheDDDDt @HappenLee