Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](multi-catalog) delete hdfs hedged configs at BE side. #25094

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

dutyu
Copy link
Contributor

@dutyu dutyu commented Oct 7, 2023

Proposed changes

Issue Number: close #25093

We can set hdfs hedged configs when creating catalog, just like this:

CREATE CATALOG `test_ctl` PROPERTIES (
...
"dfs.client.hedged.read.threadpool.size" = "128",
"dfs.client.hedged.read.threshold.millis" = "500",
...
);

It is redundant to set these configs at BE side, and it will brings an occasional bug at #25093 .

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@dutyu
Copy link
Contributor Author

dutyu commented Oct 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@dutyu
Copy link
Contributor Author

dutyu commented Oct 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@dutyu dutyu changed the title [Fix](multi-catalog) delete hdfs hedged configs at be. [Fix](multi-catalog) delete hdfs hedged configs at BE size. Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8151/22458)
Line Coverage: 28.41% (65169/229402)
Region Coverage: 27.35% (33759/123426)
Branch Coverage: 24.02% (17218/71682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1fcfc199745826c3d617e503883cf46e6fac5759_1fcfc199745826c3d617e503883cf46e6fac5759/report/index.html

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.40% (65143/229402)
Region Coverage: 27.34% (33742/123426)
Branch Coverage: 24.01% (17209/71682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ecf9fbeb7c6df50f0c80df0840050e9077255e0_3ecf9fbeb7c6df50f0c80df0840050e9077255e0/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.8 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162274173 Bytes

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.96 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162343348 Bytes

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8151/22458)
Line Coverage: 28.41% (65174/229402)
Region Coverage: 27.35% (33761/123426)
Branch Coverage: 24.02% (17218/71682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ecf9fbeb7c6df50f0c80df0840050e9077255e0_3ecf9fbeb7c6df50f0c80df0840050e9077255e0/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.67 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162474097 Bytes

@dutyu dutyu changed the title [Fix](multi-catalog) delete hdfs hedged configs at BE size. [Fix](multi-catalog) delete hdfs hedged configs at BE side. Oct 7, 2023
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@morningman morningman merged commit e41b03e into apache:master Oct 11, 2023
xiaokang pushed a commit that referenced this pull request Oct 12, 2023
Issue Number: close #25093

We can set hdfs hedged configs when creating catalog, just like this:
```
CREATE CATALOG `test_ctl` PROPERTIES (
...
"dfs.client.hedged.read.threadpool.size" = "128",
"dfs.client.hedged.read.threshold.millis" = "500",
...
);
```
It is redundant to set these configs at BE side, and it will brings an occasional bug at #25093 .
dutyu added a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…5094)

Issue Number: close apache#25093 

We can set hdfs hedged configs when creating catalog, just like this:
```
CREATE CATALOG `test_ctl` PROPERTIES (
...
"dfs.client.hedged.read.threadpool.size" = "128",
"dfs.client.hedged.read.threshold.millis" = "500",
...
);
```
It is redundant to set these configs at BE side, and it will brings an occasional bug at apache#25093 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Query hive table failed with hdfs hedged enabled
5 participants