-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](multi-catalog) delete hdfs hedged configs at BE side. #25094
Conversation
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TeamCity be ut coverage result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Issue Number: close #25093 We can set hdfs hedged configs when creating catalog, just like this: ``` CREATE CATALOG `test_ctl` PROPERTIES ( ... "dfs.client.hedged.read.threadpool.size" = "128", "dfs.client.hedged.read.threshold.millis" = "500", ... ); ``` It is redundant to set these configs at BE side, and it will brings an occasional bug at #25093 .
…5094) Issue Number: close apache#25093 We can set hdfs hedged configs when creating catalog, just like this: ``` CREATE CATALOG `test_ctl` PROPERTIES ( ... "dfs.client.hedged.read.threadpool.size" = "128", "dfs.client.hedged.read.threshold.millis" = "500", ... ); ``` It is redundant to set these configs at BE side, and it will brings an occasional bug at apache#25093 .
Proposed changes
Issue Number: close #25093
We can set hdfs hedged configs when creating catalog, just like this:
It is redundant to set these configs at BE side, and it will brings an occasional bug at #25093 .
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...