Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](join) corner case cause the mark join + null aware left join core dump in regression test in pipeline query engine #25087

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

HappenLee
Copy link
Contributor

Proposed changes

Issue Number: close #24804

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

run buildall

…re dump in regression test in pipeline query engine
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.30% (8152/22458)
Line Coverage: 28.42% (65204/229398)
Region Coverage: 27.36% (33761/123416)
Branch Coverage: 24.02% (17221/71680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7086b52ad89d601b89c814b027358efd380c5100_7086b52ad89d601b89c814b027358efd380c5100/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.75 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162525503 Bytes

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by anyone and no changes requested.

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22454)
Line Coverage: 28.43% (65185/229299)
Region Coverage: 27.35% (33774/123479)
Branch Coverage: 24.03% (17215/71634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/84365e707afc2a5037a7bf8d88dda974771aac70_84365e707afc2a5037a7bf8d88dda974771aac70/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.52 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162131697 Bytes

@HappenLee HappenLee merged commit 5c020be into apache:master Oct 8, 2023
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Oct 13, 2023
…re dump in regression test in pipeline query engine (apache#25087)
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Oct 13, 2023
…re dump in regression test in pipeline query engine (apache#25087)
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Oct 13, 2023
…re dump in regression test in pipeline query engine (apache#25087)
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
…re dump in regression test in pipeline query engine (#25087) (#25411)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…re dump in regression test in pipeline query engine (apache#25087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants