Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](testcase) add state check for ADD INDEX before BUILD INDEX to avoid table state not normal #25038

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Oct 3, 2023

Proposed changes

Issue Number: close #xxx

add state check for ADD INDEX before BUILD INDEX in index change testcases.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiaokang
Copy link
Contributor Author

xiaokang commented Oct 3, 2023

run buildall

1 similar comment
@zgxme
Copy link
Contributor

zgxme commented Oct 4, 2023

run buildall

@xiaokang
Copy link
Contributor Author

xiaokang commented Oct 4, 2023

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 136973d into apache:master Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

PR approved by anyone and no changes requested.

vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
xiaokang added a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants